-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'make fmt-check' #18634
Fix 'make fmt-check' #18634
Conversation
There is one difference in the arguments, |
`make fmt-check` did not run all commands that `make fmt` did, resulting in missed diffs. Fix that by just depending on the `fmt` target. Includes: go-gitea#18633
|
The problem is that gitea-fmt doesn't properly support the |
This implements -l, -w and -d with gitea-fmt and merges gofumpt. Signed-off-by: Andrew Thornton <art27@cantab.net>
I think my version was fine. We want it to just alter the files in-place in both cases. No need for duplicate code that risk going out of sync on careless edits. |
I'm gonna merge this in to your other PR. |
Can you make it so |
Nope they're calling different args - one is doing diff and one is writing files. |
Seems a bit pointless to not just rely on |
then fmt-check is dependent on the the status of your git index which is very non-ideal. |
Does it matter when the target realistically is only triggered on CI where index is clean? |
It is not only triggered on CI. |
make fmt-check
did not run all commands thatmake fmt
did, resultingin missed diffs. Fix that by just depending on the
fmt
target.Includes: #18633