Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer show the db-downgrade SQL in production #18653

Merged
merged 3 commits into from Feb 7, 2022
Merged

No longer show the db-downgrade SQL in production #18653

merged 3 commits into from Feb 7, 2022

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Feb 7, 2022 •
edited

I see many users force downgrading their database from 1.16 to 1.15.

Actually the database structure might change a lot across release, such operation is very risky.

We had better only show the downgrade SQL in development.

Your database (migration version: 210) is for a newer Gita, you can not use the newer database for this old Gitea release (209).
Gitea will exit to keep your database safe and unchanged. Please use the correct Gitea release, do not change the migration version manually (incorrect manual operation may lose data).
(only in development) If you are in development and really know what you're doing, you can force changing the migration version by executing: UPDATE version SET version=209 WHERE id=1;

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 7, 2022
@techknowlogick techknowlogick added backport/v1.16 and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 7, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 7, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 7, 2022
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 7, 2022
@wxiaoguang wxiaoguang mentioned this pull request Feb 7, 2022
Merged
@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Feb 7, 2022
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Feb 7, 2022
@lafriks lafriks merged commit 47c1b62 into go-gitea:main Feb 7, 2022
@wxiaoguang wxiaoguang deleted the fix-db-downgrade branch February 7, 2022 10:06
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 8, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
06817b1 
* giteaofficial/main: (28 commits)
  Added auto-save whitespace behavior if it changed manually (go-gitea#15566)
  Support custom ACME provider (go-gitea#18340)
  Refactor i18n, use Locale to provide i18n/translation related functions (go-gitea#18648)
  Only request write when necessary (go-gitea#18657)
  [skip ci] Updated translations via Crowdin
  Add separate SSH_USER config option (go-gitea#17584)
  Be more lenient with label colors (go-gitea#17752)
  remove redundant call to UpdateRepoStats during migration (go-gitea#18591)
  more repo dump/restore tests, including pull requests (go-gitea#18621)
  No longer show the db-downgrade SQL in production (go-gitea#18653)
  Fix the missing i18n key for update checker (go-gitea#18646)
  Update gitea-vet (go-gitea#18640)
  Future proof for 1.18 (go-gitea#18644)
  Add `contrib/upgrade.sh` (go-gitea#18286)
  If rendering has failed due to a net.OpError stop rendering (go-gitea#18642)
  Delete old git.NewCommand() and use it as git.NewCommandContext() (go-gitea#18552)
  Update JS dependencies (go-gitea#18636)
  fix commits_list_small.tmpl (go-gitea#18641)
  Fix `make fmt` and `make fmt-check` (go-gitea#18633)
  Frontport of changelog for v1.16.1 (go-gitea#18615)
  ...
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@wxiaoguang
No longer show the db-downgrade SQL in production (go-gitea#18653)
2bf08ed 
* make messages more friendly
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wxiaoguang @techknowlogick @KN4CK3R @lafriks @GiteaBot