Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add "ring" message logger to review last N messages on /admin/logging #18858

Closed
wants to merge 1 commit into from

Conversation

zeripath
Copy link
Contributor

Add a ring message logger to make it possible to see the last N log messages from the admin settings screen.

Very much WIP. UI not ready etc.

Current hacky way to add in the messages logger is to add:

[log]
MODE=console,messages; e.g. just append messages to current logging settings.
...

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath zeripath added type/enhancement An improvement of existing functionality pr/wip This PR is not ready for review labels Feb 22, 2022
@wxiaoguang
Copy link
Contributor

Just FYI: there was an old issue for this:

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 22, 2022
@wxiaoguang wxiaoguang linked an issue Feb 22, 2022 that may be closed by this pull request
@6543
Copy link
Member

6543 commented Feb 22, 2022

NOTE: this ring buffer does live within an instance ... for clustering this will be an issue ...

@singuliere
Copy link
Contributor

NOTE: this ring buffer does live within an instance ... for clustering this will be an issue ...

What is clustering?

@singuliere
Copy link
Contributor

What about adding a method to get the current content of a named provider? It could be empty if the provider does not support that (smtp for instance). Or it could be the full content of the log file for the file provider. Or the content of the rotated list of messages for this new provider.

@silverwind
Copy link
Member

silverwind commented Feb 23, 2022

What is clustering?

I think it means multiple gitea instances running off the same databases/cache/filesystem with traffic load-balanced between them. Any data specific to a single instance is problematic in such a case, it must be in a shared databases/cache/filesystem.

WIP: not ready yet.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@stale
Copy link

stale bot commented Apr 30, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 30, 2022
@yardenshoham
Copy link
Member

This is in progress for a while now, I'm closing it to avoid stale pull requests. Please reopen when it's ready for review.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/stale lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. pr/wip This PR is not ready for review type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log option on admin area
7 participants