Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accounts with WebAuthn only (no TOTP) now exist ... fix code to handle that case #18897

Merged
merged 8 commits into from Mar 2, 2022
Merged

Accounts with WebAuthn only (no TOTP) now exist ... fix code to handle that case #18897

merged 8 commits into from Mar 2, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 25, 2022

as title

@6543 6543 added this to the 1.16.3 milestone Feb 25, 2022
@6543
Copy link
Member Author

6543 commented Feb 25, 2022

we should seperate twofactor auth and TOTP things!!!

at the moment TOTP is referenced as twofactor in the code a lot ... but it's just one of two auth sources who are for 2fa !!!

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 25, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@a5e8dae). Click here to learn what that means.
The diff coverage is 38.46%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18897   +/-   ##
=======================================
  Coverage        ?   46.62%           
=======================================
  Files           ?      854           
  Lines           ?   122585           
  Branches        ?        0           
=======================================
  Hits            ?    57154           
  Misses          ?    58533           
  Partials        ?     6898
Impacted Files Coverage Δ
routers/web/admin/users.go 38.99% <13.04%> (ø)
models/user/list.go 87.75% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5e8dae...049f5d4. Read the comment docs.

@lunny lunny removed this from the 1.16.3 milestone Feb 25, 2022
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 25, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 25, 2022
zeripath
zeripath reviewed Feb 26, 2022
View reviewed changes
models/user/list.go Outdated Show resolved Hide resolved
@6543 6543 requested a review from zeripath March 1, 2022 00:20
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 1, 2022
@6543
Copy link
Member Author

6543 commented Mar 2, 2022

🚀

@6543 6543 merged commit 1f45d1e into go-gitea:main Mar 2, 2022
@6543 6543 deleted the fix-2fa-detection-and-deletion branch March 2, 2022 00:24
6543 added a commit to 6543-forks/gitea that referenced this pull request Mar 2, 2022
@6543
Accounts with WebAuthn only (no TOTP) now exist ... fix code to handl…
41ba451 
…e that case (go-gitea#18897)
@6543 6543 mentioned this pull request Mar 2, 2022
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Mar 2, 2022
@6543
Copy link
Member Author

6543 commented Mar 2, 2022

-> #18964

@6543 6543 added this to the 1.17.0 milestone Mar 2, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 2, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9a7a780 
* giteaofficial/main:
  Send 404 on `/{org}.gpg` (go-gitea#18959)
  Accounts with WebAuthn only (no TOTP) now exist ... fix code to handle that case (go-gitea#18897)
  Fix lfs management setting (go-gitea#18946)
  Fix admin user list pagination (go-gitea#18957)
jolheiser pushed a commit that referenced this pull request Mar 2, 2022
@6543
Accounts with WebAuthn only (no TOTP) now exist ... fix code to handl…
f9b6404 
…e that case (#18897) (#18964)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@6543
Accounts with WebAuthn only (no TOTP) now exist ... fix code to handl…
e772d12 
…e that case (go-gitea#18897)
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@Gusted Gusted Gusted approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@6543 @codecov-commenter @zeripath @Gusted @lunny @GiteaBot