Refactor mirror code & fix StartToMirror
#18904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the MirrorID as index(SQL uses `id` column not the `repo_id`). Passes the Mirror ID's into the Sync functions.
lunny
added
the
pr/breaking
|
I think this is right because one push mirror repository could have serval remote repositories. But this is potential break for those have tasks in the mirror queue. |
GiteaBot
added
the
lgtm/need 2
|
I think because of this PR the |
lunny
reviewed
Feb 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #18904 +/- ##
=======================================
Coverage ? 46.66%
=======================================
Files ? 854
Lines ? 122576
Branches ? 0
=======================================
Hits ? 57199
Misses ? 58485
Partials ? 6892
Continue to review full report at Codecov.
|
lunny
approved these changes
Feb 26, 2022
GiteaBot
added
lgtm/need 1
KN4CK3R
reviewed
Feb 28, 2022
Gusted
changed the title
StartToMirror
|
Added a fix to |
lunny
reviewed
Mar 1, 2022
lunny
approved these changes
Mar 1, 2022
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
KN4CK3R
approved these changes
Mar 1, 2022
GiteaBot
added
lgtm/done
|
make L-G-T-M work. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 2, 2022
* giteaoffical/main: Refactor mirror code & fix `StartToMirror` (go-gitea#18904)
Gusted
added a commit
to Gusted/gitea
that referenced
this pull request
Mar 14, 2022
lunny
pushed a commit
that referenced
this pull request
Mar 14, 2022
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Use MirrorID instead of RepoID - Use the MirrorID as index(SQL uses `id` column not the `repo_id`). Passes the Mirror ID's into the Sync functions. * Check for MirrorID == 0 * Fix `StartToMirror` + refactor * Update services/mirror/mirror.go Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idcolumn not therepo_id, which currently seems to be expected). Passes the Mirror ID's into the Sync functions.StartToMirrorto start Pull sync request for given repo.I'm not actually sure if this fixes issues like #18860, but it's regardless a bug IMO as a repo could have multiple push mirrors.