Don't update email for organisation #18905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gusted
commented
Feb 26, 2022
Gusted
commented
- Fix regression caused by: f1b1472
- Don't try to insert a email for Organization(as they don't have one).
- Resolves HTTP 500 when changing Organization Full Name #18891
- Fix regression caused by: f1b1472 - Don't try to insert a email for Organisation(as they don't have one). - Resolves go-gitea#18891
Gusted
added
the
issue/regression
silverwind
approved these changes
Feb 26, 2022
GiteaBot
added
the
lgtm/need 1
Gusted
added a commit
to Gusted/gitea
that referenced
this pull request
Feb 26, 2022
|
Even organization could have an email address. But currently no verify UI for it. So I think this is a temporary resolution. |
lunny
approved these changes
Feb 26, 2022
GiteaBot
added
lgtm/done
6543
pushed a commit
that referenced
this pull request
Feb 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #18905 +/- ##
=======================================
Coverage ? 46.64%
=======================================
Files ? 854
Lines ? 122561
Branches ? 0
=======================================
Hits ? 57164
Misses ? 58502
Partials ? 6895
Continue to review full report at Codecov.
|
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 27, 2022
* giteaofficial/main: Fix page and missing return on unadopted repos API (go-gitea#18848) [skip ci] Updated licenses and gitignores Allow adminstrator teams members to see other teams (go-gitea#18918) Update nginx reverse proxy docs (go-gitea#18922) Don't treat BOM escape sequence as hidden character. (go-gitea#18909) Remove CodeMirror dependencies (go-gitea#18911) Uncapitalize errors (go-gitea#18915) Disable service worker by default (go-gitea#18914) Set is_empty in fixtures (go-gitea#18869) Don't update email for organisation (go-gitea#18905) Correctly link URLs to users/repos with dashes, dots or underscores (go-gitea#18890) Set is_private in fixtures. (go-gitea#18868) Fix team management UI (go-gitea#18886) Update JS dependencies (go-gitea#18898) Fix migration v210 (go-gitea#18892) migrations: add test for importing pull requests in gitea uploader (go-gitea#18752)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
- Fix regression caused by: f1b1472 - Don't try to insert a email for Organisation(as they don't have one). - Resolves go-gitea#18891 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.