Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the deletion of issue #18945

Merged
merged 7 commits into from Mar 2, 2022
Merged

Improve the deletion of issue #18945

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b8fcc9
Improve the deletion of issue
lunny Mar 1, 2022
6691599
fix
6543 Mar 1, 2022
e937f62
Merge branch 'main' into lunny/improve_delete_issue
6543 Mar 1, 2022
3160a3f
Merge branch 'main' into lunny/improve_delete_issue
6543 Mar 1, 2022
9324464
Merge branch 'main' into lunny/improve_delete_issue
lunny Mar 2, 2022
36fa3eb
Merge branch 'main' into lunny/improve_delete_issue
6543 Mar 2, 2022
561005f
Merge branch 'main' into lunny/improve_delete_issue
6543 Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 9 additions & 9 deletions models/issue.go
View file
Open in desktop
Expand Up @@ -2043,17 +2043,17 @@ func deleteIssue(ctx context.Context, issue *Issue) error {
}

// delete actions assigned to this issue
var comments []int64
if err := e.Table(new(Comment)).In("issue_id", issue.ID).Cols("id").Find(&comments); err != nil {
subQuery := builder.Select("`id`").
From("`comment`").
Where(builder.Eq{"`issue_id`": issue.ID})
if _, err := e.In("comment_id = ?", subQuery).Delete(&Action{}); err != nil {
6543 marked this conversation as resolved.
Show resolved Hide resolved
return err
}
for i := range comments {
if _, err := e.Where("comment_id = ?", comments[i]).Delete(&Action{}); err != nil {
return err
}
}
if _, err := e.Table("action").Where("repo_id = ?", issue.RepoID).In("op_type", ActionCreateIssue, ActionCreatePullRequest).
Where("content LIKE ?", strconv.FormatInt(issue.ID, 10)+"|%").Delete(&Action{}); err != nil {

if _, err := e.Table("action").Where("repo_id = ?", issue.RepoID).
In("op_type", ActionCreateIssue, ActionCreatePullRequest).
Where("content LIKE ?", strconv.FormatInt(issue.ID, 10)+"|%").
Delete(&Action{}); err != nil {
return err
}

Expand Down