Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix newAttachmentPaths deletion for DeleteRepository() #18973

Merged
merged 3 commits into from Mar 3, 2022
Merged

Fix newAttachmentPaths deletion for DeleteRepository() #18973

merged 3 commits into from Mar 3, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 2, 2022

as title

6543 added a commit to 6543-forks/gitea that referenced this pull request Mar 2, 2022
@6543
backport fix of go-gitea#18973
3498651
@6543 6543 mentioned this pull request Mar 2, 2022
Merged
@6543 6543 added type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 2, 2022
@6543 6543 added this to the 1.17.0 milestone Mar 2, 2022
@6543
Copy link
Member Author

6543 commented Mar 2, 2022

-> #18974

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 2, 2022
@fnetX
Copy link
Contributor

fnetX commented Mar 2, 2022

I suppose I should drop the attempted fix from my PR then?

@6543
Copy link
Member Author

6543 commented Mar 2, 2022

well asap it got merged you will have a merge conflict 🗡️

@6543 6543 requested review from zeripath and Gusted March 2, 2022 19:07
@6543 6543 changed the title DeleteRepository: fix & refactor Fix newAttachmentPaths deletion for DeleteRepository() Mar 2, 2022
Gusted
Gusted approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@Gusted Gusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to safe to have this, but generally it can be dangerous to loop over a slice with pointers.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 2, 2022
zeripath pushed a commit that referenced this pull request Mar 2, 2022
@6543
backport fix of #18973 (#18974)
4317806
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2022
@lunny
Copy link
Member

lunny commented Mar 3, 2022

this could be backport to v1.16

@fnetX
Copy link
Contributor

fnetX commented Mar 3, 2022

@lunny backport was already done in #18974.

@lunny lunny added the backport/done All backports for this PR have been created label Mar 3, 2022
@lunny
Copy link
Member

lunny commented Mar 3, 2022

@lunny backport was already done in #18974.

Yes, I know. So I added the missed labels.

@lunny lunny merged commit eddd2fb into go-gitea:main Mar 3, 2022
@6543 6543 deleted the fix-nit branch March 3, 2022 14:31
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Mar 3, 2022
@a1012112796
Merge branch 'main' into wiki_link
6f20718 
* main:
  ignore missing comment for user notifications (go-gitea#18954)
  allow overwrite artifacts for github releases (go-gitea#18987)
  fix & refactor (go-gitea#18973)
  Don't clean up hardcoded `tmp` (go-gitea#18983)
  git backend ignore replace objects (go-gitea#18979)
  Improve the deletion of issue (go-gitea#18945)
  Add note to GPG key response if user has no keys (go-gitea#18961)
  adds restore docs for docker based instances (go-gitea#18844)
  Refactor admin user filter query parameters (go-gitea#18965)
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 6, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
26c0a78 
* giteaofficial/main:
  Fix EasyMDE error when input Enter (go-gitea#19004)
  Fix update hint bug (go-gitea#18996)
  Fix the editor height in review box (go-gitea#19003)
  Add a "admin user generate-access-token" subcommand (go-gitea#17722)
  Fix potential assignee query for repo (go-gitea#18994)
  Add config option to disable "Update branch by rebase" (go-gitea#18745)
  Update `go-enry` to v2.8.0 (go-gitea#18993)
  homebrew updates via cron
  ignore missing comment for user notifications (go-gitea#18954)
  allow overwrite artifacts for github releases (go-gitea#18987)
  fix & refactor (go-gitea#18973)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@6543 @lunny
fix & refactor (go-gitea#18973)
375703e 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@Gusted Gusted Gusted approved these changes

@zeripath zeripath Awaiting requested review from zeripath

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@6543 @fnetX @lunny @Gusted @GiteaBot