Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove util.IsIPPrivate as it is no longer needed #19128

Merged
merged 1 commit into from Mar 18, 2022
Merged

Remove util.IsIPPrivate as it is no longer needed #19128

merged 1 commit into from Mar 18, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 18, 2022

just delete not needed code

@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 18, 2022
@6543 6543 added this to the 1.17.0 milestone Mar 18, 2022
@6543 6543 mentioned this pull request Mar 18, 2022
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 18, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 18, 2022
@6543 6543 merged commit 60fbaa9 into go-gitea:main Mar 18, 2022
@6543 6543 deleted the refactor-rm-uneeded branch March 18, 2022 19:18
@zeripath zeripath changed the title remove not needed Remove util.IsIPPrivate as it is no longer needed Mar 18, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 19, 2022
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
9d7ab3c 
* giteaoffical/main:
  remove not needed (go-gitea#19128)
  Add warning to set SENDMAIL_ARGS to --  (go-gitea#19102)
  Do not send activation email if manual confirm is set (go-gitea#19119)
  Update tool dependencies (go-gitea#19120)
  Delete related notifications on issue deletion too (go-gitea#18953)
  nit fix (go-gitea#19116)
  Store the foreign ID of issues during migration  (go-gitea#18446)
  Remove italics for `due_date_not_set` (go-gitea#19113)
6543 added a commit to techknowlogick/gitea that referenced this pull request Mar 19, 2022
@6543
remove not needed (go-gitea#19128)
bafede0
6543 added a commit that referenced this pull request Mar 19, 2022
@techknowlogick @silverwind
@6543 @zeripath @MrGussio
Bump to build with go1.18 (#19120 et al) (#19127)
f9ea4ab 
Backport #19120 
Backport #19099 
Backport #18874 
Backport #18420
Backport #19128
Backport #18270 

Bump to build with go1.18

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Jelle Hulter <jellehulter@gmail.com>
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@6543
remove not needed (go-gitea#19128)
72a56fd
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@Gusted Gusted Gusted approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@6543 @zeripath @Gusted @delvh @GiteaBot