Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove package cleanup debug logs #19293

Closed
wants to merge 1 commit into from
Closed

Remove package cleanup debug logs #19293

wants to merge 1 commit into from

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Apr 1, 2022

Forgot to remove some debug logs.

@KN4CK3R KN4CK3R added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 1, 2022
@KN4CK3R KN4CK3R mentioned this pull request Apr 1, 2022
Open
26 tasks
@wxiaoguang
Copy link
Contributor

No hurry, let's see if there are something more to be improved.

And I am going to see why the error hier2 happens on my side, it shouldn't ..... 😊

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 1, 2022
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 1, 2022 •
edited

Some issues:

  1. The error is Error 1093: You can't specify target table 'package' for update in FROM clause (DeletePackagesIfUnreferenced)
  2. The ctx in Cleanup is not used, I think it should be used .....

@KN4CK3R
Copy link
Member Author

KN4CK3R commented Apr 1, 2022

Found some flaws. Will create a broader PR later.

@KN4CK3R KN4CK3R closed this Apr 1, 2022
@KN4CK3R
Copy link
Member Author

KN4CK3R commented Apr 1, 2022 

2. The `ctx` in `Cleanup` is not used, I think it should be used .....

But I need a transaction here. I found no way to combine both.

@KN4CK3R KN4CK3R deleted the fix-debug-log branch April 1, 2022 06:48
@KN4CK3R
Copy link
Member Author

KN4CK3R commented Apr 1, 2022

Your error should be fixed in #19305.

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KN4CK3R @wxiaoguang @GiteaBot