Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github style following followers #19482

Merged
merged 5 commits into from
May 25, 2022
Merged

Github style following followers #19482

merged 5 commits into from
May 25, 2022

Conversation

istiak101
Copy link
Contributor

Removed tabbed following and followers from user page and added Github style following followers.

@Gusted
Copy link
Contributor

Gusted commented Apr 25, 2022

image
The CSS is currently not correct.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 25, 2022
@istiak101
Copy link
Contributor Author

Screenshot from 2022-04-25 16-19-50
I am not sure which branch you're on. I tested this locally with 1.16.6. But in no case username would flow to next line as I am checking currently with different viewports and devices on browser dev tools.

@Gusted
Copy link
Contributor

Gusted commented Apr 25, 2022

I am not sure which branch you're on. I tested this locally with 1.16.6. But in no case username would flow to next line as I am checking currently with different viewports and devices on browser dev tools.

You're currently targeting the main branch(which is 1.17), could be just me, but the current layout doesn't seem to be correct.

@istiak101
Copy link
Contributor Author

You're currently targeting the main branch(which is 1.17), could be just me, but the current layout doesn't seem to be correct.

I would deploy 1.17 just in case if I can reproduce this. I will send css patch if I can with this same PR.

@a1012112796 a1012112796 added the topic/ui Change the appearance of the Gitea UI label Apr 26, 2022
@6543 6543 added the topic/ui-interaction Change the process how users use Gitea instead of the visual appearance label Apr 29, 2022
@Gusted Gusted added this to the 1.17.0 milestone May 3, 2022
silverwind
silverwind reviewed May 19, 2022
View reviewed changes
templates/user/profile.tmpl Outdated
Comment on lines 20 to 22
<i class="ui grey icon tooltip ml-3">{{svg "octicon-person" 18}}</i>
<a href="{{.Owner.HomeLink}}?tab=followers">{{.Owner.NumFollowers}} {{.i18n.Tr "user.followers"}}</a> .
<a href="{{.Owner.HomeLink}}?tab=following">{{.Owner.NumFollowing}} {{.i18n.Tr "user.following"}}</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<i class="ui grey icon tooltip ml-3">{{svg "octicon-person" 18}}</i>
<a href="{{.Owner.HomeLink}}?tab=followers">{{.Owner.NumFollowers}} {{.i18n.Tr "user.followers"}}</a> .
<a href="{{.Owner.HomeLink}}?tab=following">{{.Owner.NumFollowing}} {{.i18n.Tr "user.following"}}</a>
<a class="muted" href="{{.Owner.HomeLink}}?tab=followers">{{svg "octicon-person" 18 "mr-2"}}{{.Owner.NumFollowers}} {{.i18n.Tr "user.followers"}}</a> · <a class="muted" href="{{.Owner.HomeLink}}?tab=following">{{.Owner.NumFollowing}} {{.i18n.Tr "user.following"}}</a>

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion. I really needed the "muted" class.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything missing? The UI on try.gitea.io is not the same as the screenshot.

@istiak101
Copy link
Contributor Author

I built the main branch. The CSS is indeed incorrect on 1.17(ba7750d). 1.16 branch is fine. I will check the CSS diff on both on both branch.

@istiak101 @silverwind
muted class for links
4a384ef 
text-decoration: none; for follower, following links

Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 21, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 21, 2022
@wxiaoguang wxiaoguang merged commit 35d0358 into go-gitea:main May 25, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 25, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
727d7a0 
* giteaofficial/main:
  Github style following followers (go-gitea#19482)
  alpine 3.16 (go-gitea#19797)
@wxiaoguang
Copy link
Contributor

Hmmm ....... it's broken ......

https://try.gitea.io/wxiaoguang

image

@silverwind silverwind mentioned this pull request May 25, 2022
Merged
@silverwind
Copy link
Member

Ooops, I forgot to suggest the wrapper div, fix in #19805.

AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@istiak101 @AbdulrhmnGhanem
Github style following followers (go-gitea#19482)
479a499 
Removed tabbed following and followers from user page and added Github style following followers.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

@Gusted Gusted Gusted approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@istiak101 @Gusted @wxiaoguang @silverwind @GiteaBot @6543 @a1012112796 @lunny