Fix duplicate entry error when add team member #19702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
reviewed
May 14, 2022
| @@ -496,6 +496,12 @@ func AddTeamMember(team *organization.Team, userID int64) error { | |||
| } | |||
| defer committer.Close() | |||
|
|
|||
| // check in transaction | |||
| isAlreadyMember, err = organization.IsTeamMember(ctx, team.OrgID, team.ID, userID) | |||
| if err != nil || isAlreadyMember { | |||
There was a problem hiding this comment.
But err is nil when isAlreadyMember is true.
There was a problem hiding this comment.
it will return nil than, this should be fine
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
May 14, 2022
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
May 14, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 14, 2022
* giteaofficial/main: Fix duplicate entry error when add team member (go-gitea#19702) [Refactor] convert team(s) to apiTeam(s) (go-gitea#13745)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix duplicate entry error when add a team member(#19697)