Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Setpgid on child git processes #19865

Merged
merged 11 commits into from Jun 3, 2022
Merged

Set Setpgid on child git processes #19865

merged 11 commits into from Jun 3, 2022

Commits on Jun 1, 2022

  1. Set Setpgid on child git processes 

    When Gitea is running as PID 1 git will occassionally orphan child processes leading
to (defunct) processes. This PR simply sets Setpgid to true on these child processes
meaning that these defunct processes will also be correctly killed.

Fix go-gitea#19077

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    b2584a2 View commit details
    Browse the repository at this point in the history

  2. OK windows does not have this 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    dfaff61 View commit details
    Browse the repository at this point in the history

  3. oops 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    e4b90e2 View commit details
    Browse the repository at this point in the history

  4. try to get the go:build to work properly 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    d82bd95 View commit details
    Browse the repository at this point in the history

  5. Update modules/git/command_windows.go 

    Co-authored-by: singuliere <35190819+singuliere@users.noreply.github.com>
    @zeripath @singuliere
    zeripath and singuliere committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    5b7f201 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review

    @techknowlogick
    techknowlogick committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    4dc3c63 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review

    @zeripath
    zeripath committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    5d1941e View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Merge branch 'main' into set-pgid-on-child-processes

    @jolheiser
    jolheiser committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    c6f274f View commit details
    Browse the repository at this point in the history

  2. Extend to all other uses of CommandContext 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    fd060fa View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Merge branch 'main' into set-pgid-on-child-processes

    @zeripath
    zeripath committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    0eabaf3 View commit details
    Browse the repository at this point in the history

  2. Update modules/process/manager_unix.go 

    Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
    @zeripath @wxiaoguang
    zeripath and wxiaoguang committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    4498295 View commit details
    Browse the repository at this point in the history