Always return valid go-get meta, even if unauthorized

[bkcsoft]

(Not leaking information, returns valid metadata for ALL requests... even broken ones...)

This is required because go get doesn't know about .netrc

[tboerger]

LGTM

[lafriks]

It will leak users/organizations, it should skip searching for repository by name if there is error and never return 500 or any other error

[bkcsoft]

Seems to be fetching the default branch-name, so if err { branchName = "master" } ?

[lafriks]

I would say something like that:

			owner, err := models.GetUserByName(ownerName)
			if err == nil {
				repo, err := models.GetRepositoryByName(owner.ID, repoName)
				if err == nil && len(repo.DefaultBranch) > 0 {
					branchName = repo.DefaultBranch
				}
			}

[lunny]

Maybe just return meta tag with no GetUserByName and GetRepositoryByName.

[bkcsoft]

Done :)

[lunny]

Just return even if repo is not exist.

[lunny]

Maybe just return meta tag with no GetUserByName and GetRepositoryByName.

[bkcsoft]

Now it should be done :) @lunny

[lafriks]

LGTM

[bkcsoft]

@lunny that would break default branches 🙄

[lunny]

Where?

[bkcsoft]

@lunny

Maybe just return meta tag with no GetUserByName and GetRepositoryByName.

☝️ that 😄