-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepend refs/heads/ to issue template refs #20461
Merged
Merged
Commits on Jul 23, 2022
-
Prepend refs/heads/ to issue template refs
Fix go-gitea#20456 At some point during the 1.17 cycle abbreviated refs to issue branches started breaking. This is likely due serious inconsistencies in our management of refs throughout Gitea - which is a bug needing to be addressed in a different PR. (Likely more than one) We should try to use non-abbreviated refs as much as possible. That is where a user has inputted a abbreviated ref we should add refs/heads/ if it is branch etc. I know people keep writing and merging PRs that remove prefixes from stored content but it is just wrong and it keeps causing problems like this. We should only remove the prefix at the time of presentation as the prefix is the only way of knowing umambiguously and permanently if the ref is referring to a branch, tag or commit. We need to make it so that every ref has the appropriate prefix, and probably also need to come up with some definitely unambiguous way of storing SHAs if they're used in a ref field. We must not store potentially ambiguous refs. (Especially tagnames - there is no reason why users cannot create a branch with the same short name as a tag and vice versa and any attempt to prevent this will fail. You can even create a branch and a tag that matches a SHA1 pattern.) To that end in order to fix this bug, when parsing issue templates check the provided Ref, if it does not start with refs/ add the BranchPrefix to it. This allows people to make their templates refer to a tag. Next we need to handle the issue links that are already written. The links here are created with `git.RefURL` Here we see there is a bug introduced in go-gitea#17551 whereby the provided Ref can be double-escaped so we remove the incorrect external escape. (The escape added in go-gitea#17551 is in the right place - unfortunately it missed that the calling function was doing the wrong thing.) Then within RefURL we check if the unprefixed ref could actually be a SHA before defaulting that an unprefixed ref is actually a commit - if not it is assumed to be a branch. This will handle most of the problem cases excepting the very unusual cases where someone has deliberately written a branch to look like a SHA1. But please if something is called a `ref` or interpreted as a `ref` make it a full-ref before storing or using it. By all means if something is a `branch` assume the prefix is removed but always add it back in if you are using it as a `ref`. Stop storing abbreviated branch names and tag names as refs. It will keep on causing problems like this. Fix go-gitea#20456 Signed-off-by: Andrew Thornton <art27@cantab.net>
Configuration menu - View commit details
-
Copy full SHA for 42d2b83 - Browse repository at this point
Copy the full SHA 42d2b83View commit details
Commits on Oct 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 17a2686 - Browse repository at this point
Copy the full SHA 17a2686View commit details
Commits on Oct 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5e72df4 - Browse repository at this point
Copy the full SHA 5e72df4View commit details
Commits on Oct 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d884d8e - Browse repository at this point
Copy the full SHA d884d8eView commit details
Commits on Nov 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 64d5282 - Browse repository at this point
Copy the full SHA 64d5282View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7195783 - Browse repository at this point
Copy the full SHA 7195783View commit details
Commits on Nov 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 082ea35 - Browse repository at this point
Copy the full SHA 082ea35View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3afb9d - Browse repository at this point
Copy the full SHA e3afb9dView commit details
Commits on Nov 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3313694 - Browse repository at this point
Copy the full SHA 3313694View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2e9637 - Browse repository at this point
Copy the full SHA b2e9637View commit details
Commits on Nov 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8cdba2b - Browse repository at this point
Copy the full SHA 8cdba2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff439a9 - Browse repository at this point
Copy the full SHA ff439a9View commit details
Commits on Nov 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5856890 - Browse repository at this point
Copy the full SHA 5856890View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f2ea08 - Browse repository at this point
Copy the full SHA 8f2ea08View commit details
Commits on Nov 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 174501d - Browse repository at this point
Copy the full SHA 174501dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a2b69ed - Browse repository at this point
Copy the full SHA a2b69edView commit details
Commits on Nov 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b0a16a1 - Browse repository at this point
Copy the full SHA b0a16a1View commit details
Commits on Nov 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f300ffe - Browse repository at this point
Copy the full SHA f300ffeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8ea8fe - Browse repository at this point
Copy the full SHA d8ea8feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d15925 - Browse repository at this point
Copy the full SHA 2d15925View commit details
Commits on Nov 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4f8a912 - Browse repository at this point
Copy the full SHA 4f8a912View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1361d81 - Browse repository at this point
Copy the full SHA 1361d81View commit details
Commits on Nov 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 21a601e - Browse repository at this point
Copy the full SHA 21a601eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5919a7 - Browse repository at this point
Copy the full SHA c5919a7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.