Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROOT_URL detection for URLs without trailing slash (#20502) #20503

Merged

Conversation

wxiaoguang
Copy link
Contributor

Backport #20502

some users visit "https://domain/gitea" while appUrl is "https://domain/gitea/", there should be no warning

@wxiaoguang wxiaoguang added type/bug topic/ui Change the appearance of the Gitea UI labels Jul 27, 2022
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Jul 27, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 27, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 27, 2022
@wxiaoguang wxiaoguang merged commit 39b2ede into go-gitea:release/v1.17 Jul 27, 2022
@wxiaoguang wxiaoguang deleted the backport-root-url-detection branch July 27, 2022 15:49
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants