Admin grammar fixes and improvements #2056
Conversation
| users.is_admin = Administrator permissions | ||
| users.allow_git_hook = Allowed to create git hooks | ||
| users.allow_import_local = Allowed to import local repositories | ||
| users.allow_create_organization = Allowed to create organizations |
There was a problem hiding this comment.
The above ones are checkboxes on the user edit page, so no need to say This account. This is why I changed these lines.
options/locale/locale_en-US.ini
Outdated
| users.still_has_org = This account still is a member of at least one organization, you need to leave or delete the organizations first. | ||
| users.deletion_success = Account has been deleted successfully. | ||
| users.delete_account = Delete Account | ||
| users.still_own_repo = This user still owns one or more repositories. These repositories need to be deleted or transfered first. |
|
LGTM |
tboerger
added
the
lgtm/need 1
options/locale/locale_en-US.ini
Outdated
| @@ -1080,8 +1080,8 @@ dashboard.delete_missing_repos = Delete all repository records which have lost t | |||
| dashboard.delete_missing_repos_success = All repository records which have lost their corresponding Git files have been deleted. | |||
| dashboard.git_gc_repos = Execute garbage collection on all repositories | |||
| dashboard.git_gc_repos_success = All repositories have finished executing garbage collection. | |||
| dashboard.resync_all_sshkeys = Rewrite '.ssh/authorized_keys' file (for Gitea SSH keys) | |||
| dashboard.resync_all_sshkeys_success = All public keys have been rewritten. | |||
| dashboard.resync_all_sshkeys = Rewrite '.ssh/authorized_keys' file (for Gitea SSH keys). Do not use this if you are using the built-in SSH server. | |||
There was a problem hiding this comment.
This should be Disabled if you are using the built-in SSH server. no? As in it won't do anything...
options/locale/locale_en-US.ini
Outdated
| dashboard.resync_all_sshkeys = Rewrite '.ssh/authorized_keys' file (for Gitea SSH keys) | ||
| dashboard.resync_all_sshkeys_success = All public keys have been rewritten. | ||
| dashboard.resync_all_sshkeys = Rewrite '.ssh/authorized_keys' file (for Gitea SSH keys). Do not use this if you are using the built-in SSH server. | ||
| dashboard.resync_all_sshkeys_success = All Gitea public keys have been rewritten. |
There was a problem hiding this comment.
All public keys controlled by Gitea [...]
options/locale/locale_en-US.ini
Outdated
| users.deletion_success = Account has been deleted successfully. | ||
| users.delete_account = Delete Account | ||
| users.still_own_repo = This user still owns one or more repositories. These repositories need to be deleted or transferred first. | ||
| users.still_has_org = This user is still is a member of one or more organizations. This user needs to leave or delete them first. |
There was a problem hiding this comment.
Is this true? Is it not only if you're an Owner of an Org?
options/locale/locale_en-US.ini
Outdated
| @@ -1180,7 +1180,7 @@ auths.host = Host | |||
| auths.port = Port | |||
| auths.bind_dn = Bind DN | |||
| auths.bind_password = Bind Password | |||
| auths.bind_password_helper = Warning: This password is stored in plain text. Do not use a highly privileged account. | |||
| auths.bind_password_helper = Warning: This password is stored in plain text. Do not use a high privilege account. | |||
There was a problem hiding this comment.
Maybe Only use a read-only account ?
|
LGTM |
tboerger
added
lgtm/done
|
Please do not merge this before 1.2.0 is released as this will break already translated strings |
|
@geek1011 rebase |
|
Any update? Or we should close this one? |
|
Sorry, I have been quite busy for the last few weeks. I will update it soon. |
|
need rebase |
Codecov Report
@@ Coverage Diff @@
## master #2056 +/- ##
=======================================
Coverage 26.91% 26.91%
=======================================
Files 87 87
Lines 17286 17286
=======================================
Hits 4652 4652
Misses 11955 11955
Partials 679 679Continue to review full report at Codecov.
|
|
@bkcsoft need your approval |
|
@lafriks CI failed |
|
need @bkcsoft approval |
|
Make LG-TM work again |
Admin grammar fixes and improvements.