Restore history button and hide add button when unable to add #20718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix two regressions from go-gitea#20602: - Restore the 'History' button that was previously unable to render because it's show condition was never hit - Hide the 'Add File' button when there would be no items in the dropdown.
Gusted
approved these changes
Aug 9, 2022
GiteaBot
added
the
lgtm/need 1
wxiaoguang
approved these changes
Aug 9, 2022
GiteaBot
added
lgtm/done
wxiaoguang
approved these changes
Aug 9, 2022
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Aug 9, 2022
…ea#20718) Fix two regressions from go-gitea#20602: - Restore the 'History' button that was previously unable to render because it's show condition was never hit - Hide the 'Add File' button when there would be no items in the dropdown. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 10, 2022
* giteaofficial/main: Fix CI status popup (go-gitea#20737) Add documentation about pagination of the API (go-gitea#20740) [skip ci] Updated translations via Crowdin Change commit status icons to SVG (go-gitea#20736) Add support for NuGet API keys (go-gitea#20721) Keep download count on Container tag overwrite (go-gitea#20728) Replace fomantic popup module with tippy.js (go-gitea#20428) Add an option to create new issues from "/issues" page (go-gitea#20650) Restore history button and hide add button when unable to add (go-gitea#20718) Remove manual rollback for failed generated repositories (go-gitea#20639)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
…ea#20718) Fix two regressions from go-gitea#20602: - Restore the 'History' button that was previously unable to render because it's show condition was never hit - Hide the 'Add File' button when there would be no items in the dropdown. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zeripath
pushed a commit
that referenced
this pull request
Aug 20, 2022
* Rework repo buttons (#20602) * Rework repo buttons - Replace "New PR" and "Go to File" button with Icon Button - Move all "Add File" actions into a dropdown button - Remove most custom styling of clone buttons - Margin and wiki tweaks Buttons are now all equal height, mobile layout wraps gracefully. Fixes: #13671 Replaces: #20375 * Restore history button and hide add button when unable to add (#20718) Fix two regressions from #20602: - Restore the 'History' button that was previously unable to render because it's show condition was never hit - Hide the 'Add File' button when there would be no items in the dropdown. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two regressions from #20602:
View this PR with whitespace changes hidden.