Increase Content field size of gpg_key and public_key to MEDIUMTEXT #20896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately some keys are too big to fix within the 65535 limit of TEXT on MySQL this causes issues with these large keys. Therefore increase these fields to MEDIUMTEXT. Fix go-gitea#20894 Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Unfortunately the migration cannot be backported to 1.17 so affected users will have to use |
GiteaBot
added
the
lgtm/need 2
delvh
approved these changes
Aug 21, 2022
GiteaBot
added
lgtm/need 1
Should we mark this PR as breaking then so that we think of it when releasing the changelog? |
Do that on the backport. |
KN4CK3R
approved these changes
Aug 21, 2022
GiteaBot
added
lgtm/done
|
Are we good on other DBs besides MySQL? |
|
Yes, only MySQL has this limitation as far as I'm aware. |
lunny
approved these changes
Aug 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #20896 +/- ##
==========================================
+ Coverage 46.74% 46.96% +0.21%
==========================================
Files 989 993 +4
Lines 136393 136766 +373
==========================================
+ Hits 63761 64232 +471
+ Misses 64778 64650 -128
- Partials 7854 7884 +30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
make lgtm wrok |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Aug 22, 2022
…o-gitea#20896) Backport go-gitea#20896 Unfortunately some keys are too big to fix within the 65535 limit of TEXT on MySQL this causes issues with these large keys. Therefore increase these fields to MEDIUMTEXT. Unfortunately the migration in go-gitea#20896 cannot be backported to 1.17 so affected users will have to use `gitea doctor recreate-table gpg_key public_key` Fix go-gitea#20894 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
that referenced
this pull request
Aug 22, 2022
…20896) (#20911) Backport #20896 Unfortunately some keys are too big to fix within the 65535 limit of TEXT on MySQL this causes issues with these large keys. Therefore increase these fields to MEDIUMTEXT. Unfortunately the migration in #20896 cannot be backported to 1.17 so affected users will have to use `gitea doctor recreate-table gpg_key public_key` Fix #20894 Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 23, 2022
* giteaofficial/main: Changelog 1.17.1 (go-gitea#20833) (go-gitea#20919) Fix typo in backup documentation (pgdump->pg_dump) (go-gitea#20913) Increase Content field size of gpg_key and public_key to MEDIUMTEXT (go-gitea#20896) Improve single repo action for issue and pull requests (go-gitea#20730) Remove deprecated licenses (go-gitea#20222)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 28, 2022
…o-gitea#20896) Unfortunately some keys are too big to fix within the 65535 limit of TEXT on MySQL this causes issues with these large keys. Therefore increase these fields to MEDIUMTEXT. Fix go-gitea#20894 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 13, 2023
Unfortunately go-gitea#20896 does not completely prevent Data too long issues and GPGImportKey needs to be increased too. Fix go-gitea#22896 Signed-off-by: Andrew Thornton <art27@cantab.net>
jolheiser
pushed a commit
that referenced
this pull request
Feb 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately some keys are too big to fix within the 65535 limit of TEXT on MySQL
this causes issues with these large keys.
Therefore increase these fields to MEDIUMTEXT.
Fix #20894
Signed-off-by: Andrew Thornton art27@cantab.net