Add custom helm repo name generated from url #21024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
21h
changed the title
silverwind
reviewed
Sep 2, 2022
routers/web/admin/admin.go
Outdated
| @@ -243,6 +243,7 @@ func Config(ctx *context.Context) { | |||
|
|
|||
| ctx.Data["CustomConf"] = setting.CustomConf | |||
| ctx.Data["AppUrl"] = setting.AppURL | |||
| ctx.Data["GiteaRepoName"] = setting.Domain | |||
There was a problem hiding this comment.
Why are you declaring both a context variable and a helper function? One of them ought to be enough and I'd lean to just using Domain which is set 1 line below this one, so we can remove both the helper and the variable.
|
Is this PR active? I think it could be easy to get approved: remove all other unnecessary |
pull-request-size
bot
added
the
size/XXL
pull-request-size
bot
added
size/XS
|
@wxiaoguang I created FRESH PR without conflicts #24363 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace helm repo name in Packages to generated from gitea instance site url. Because default "gitea" repo name has many installations in internet but repo name based on url unique for every instance.