Set SemverCompatible to false for Conan packages #21275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a question, is it necessary to report errors and show 500 when the package version can not be parsed for SemverCompatible=true? 500 error seems not friendly to user, and they can not even delete the package. |
GiteaBot
added
the
lgtm/need 2
|
If SemverCompatible=true there is a check in the upload process to enforce a valid version. This check was missing for Conan packages because Semver is not enforced by the spec. In this case a 500 error is correct because an invalid version should not occur.
|
wxiaoguang
approved these changes
Sep 30, 2022
GiteaBot
added
lgtm/need 1
delvh
reviewed
Oct 2, 2022
Co-authored-by: delvh <dev.lh@web.de>
delvh
approved these changes
Oct 3, 2022
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #21275 +/- ##
==========================================
+ Coverage 47.15% 47.51% +0.35%
==========================================
Files 1017 1017
Lines 138125 138599 +474
==========================================
+ Hits 65136 65853 +717
+ Misses 65043 64754 -289
- Partials 7946 7992 +46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
wxiaoguang
approved these changes
Oct 7, 2022
|
Merged, please send backport ~ |
KN4CK3R
added a commit
to KN4CK3R/gitea
that referenced
this pull request
Oct 7, 2022
Fixes go-gitea#21250 Related go-gitea#20414 Conan packages don't have to follow SemVer. The migration fixes the setting for all existing Conan and Generic (go-gitea#20414) packages.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 8, 2022
* upstream/main: (34 commits) Fix formatted link for PR review notifications to matrix (go-gitea#21319) Show private data in feeds (go-gitea#21369) Add nicer error handling on template compile errors (go-gitea#21350) Fix some typos and update db transaction demo in backend guideline (go-gitea#21322) Refactor parseTreeEntries, speed up tree list (go-gitea#21368) Add GET and DELETE endpoints for Docker blob uploads (go-gitea#21367) Make external issue tracker regexp configurable via API (go-gitea#21338) Add new CSS variables --color-accent and --color-small-accent (go-gitea#21305) Set SemverCompatible to false for Conan packages (go-gitea#21275) Parse OAuth Authorization header when request omits client secret (go-gitea#21351) Disable Firefox E2E tests (go-gitea#21363) Add redirect of /upgrade/ to /upgrade-from-gitea/ on docs site (go-gitea#21330) Update to go-enry v2.8.3 (go-gitea#21360) Update go to 1.19 (go-gitea#21361) SessionUser protection against nil pointer dereference (go-gitea#21358) Fix and improve incorrect error messages (go-gitea#21342) Fix default theme-auto selector when nologin (go-gitea#21346) Add `stat` to `ToCommit` function for speed (go-gitea#21337) Fix typo in API comment document (go-gitea#21347) Update comment about repository.DISABLED_REPO_UNITS in app.example.ini (go-gitea#21343) ...
lunny
pushed a commit
that referenced
this pull request
Oct 10, 2022
tyroneyeh
pushed a commit
to tyroneyeh/gitea
that referenced
this pull request
Oct 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21250
Related #20414
Conan packages don't have to follow SemVer.
The migration fixes the setting for all existing Conan and Generic (#20414) packages.