Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache session cookies in tests #2128

Merged
merged 1 commit into from
Jul 9, 2017
Merged

Cache session cookies in tests #2128

merged 1 commit into from
Jul 9, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Jul 8, 2017 •
edited
Loading

Cache session cookies in integration tests to avoid repeatedly logging in. Makes tests a little faster (make test-mysql goes from 34 to 30 seconds on my laptop)

@Bwko
Copy link
Member

Bwko commented Jul 8, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 8, 2017
@lunny lunny added this to the 1.2.0 milestone Jul 9, 2017
@lunny
Copy link
Member

lunny commented Jul 9, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 9, 2017
@lunny lunny merged commit 89cd4dd into go-gitea:master Jul 9, 2017
@ethantkoenig ethantkoenig deleted the test/cache_session branch July 9, 2017 12:08
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ethantkoenig @Bwko @lunny @tboerger