Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing signed commit display translations #2134

Merged
merged 1 commit into from
Jul 10, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jul 9, 2017

Untranslated strings when displaying signed commit info

@@ -581,6 +581,8 @@ commits.message = Message
commits.date = Date
commits.older = Older
commits.newer = Newer
commits.signed_by = Signed by
commits.gpg_key_id = GPG key ID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this one used in this PR, was it missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkcsoft fixed, I was testing if it works correctly and doing undo/redo and forgot to save latest code changes in editor :)

@lafriks lafriks force-pushed the fix/missing_gpg_translations branch from 2ee5bbc to afd1ad6 Compare July 9, 2017 21:58
@bkcsoft
Copy link
Member

bkcsoft commented Jul 10, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 10, 2017
@lunny lunny added this to the 1.2.0 milestone Jul 10, 2017
@lunny
Copy link
Member

lunny commented Jul 10, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 10, 2017
@lunny lunny merged commit 5e9bcb6 into go-gitea:master Jul 10, 2017
@lafriks lafriks deleted the fix/missing_gpg_translations branch July 10, 2017 05:11
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants