Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nicer error handling on template compile errors #21350

Merged
merged 8 commits into from
Oct 7, 2022
Merged

Add nicer error handling on template compile errors #21350

merged 8 commits into from
Oct 7, 2022

Commits on Oct 5, 2022

  1. Add nicer error handling on template compile errors 

    There are repeated issues reported whereby users are unable to interpret
the template errors. This PR adds some (somewhat complex) error handling
to the panic recovery for template renderering but hopefully makes the
interpretation of the error easier.

Reference go-gitea#21344

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    9b04b5e View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. as per delvh 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    be8d435 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ref-21344-when-panic-in-compile-try-to-find-… 

    …template-file
    @zeripath
    zeripath committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    8b20e77 View commit details
    Browse the repository at this point in the history

  3. Update modules/templates/static.go 

    Co-authored-by: delvh <dev.lh@web.de>
    @zeripath @delvh
    zeripath and delvh committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    5d086bb View commit details
    Browse the repository at this point in the history

  4. remove stacktrace and slightly adjust message 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    62fd926 View commit details
    Browse the repository at this point in the history

  5. And handle the final panic too 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    297f862 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Merge branch 'main' into ref-21344-when-panic-in-compile-try-to-find-… 

    …template-file
    @zeripath
    zeripath committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    e7d31f3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ref-21344-when-panic-in-compile-try-to-find-… 

    …template-file
    @zeripath
    zeripath committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    8caef00 View commit details
    Browse the repository at this point in the history