Disable the 'Add File' button when not able to edit repo #21503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the button would render a dropdown with zero items when `.CanEnableEditor` was false. Now it disables the button instead which is better UX.
silverwind
added
type/enhancement
delvh
approved these changes
Oct 18, 2022
GiteaBot
added
the
lgtm/need 1
wxiaoguang
approved these changes
Oct 19, 2022
GiteaBot
added
lgtm/done
|
But we can create them in forked repositories or send a pull request? |
lafriks
approved these changes
Oct 19, 2022
|
Currently it did show button and no actual submenu so it was not possible to do that anyway |
|
Correct, there is no actual behavior change with the button. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 21, 2022
* upstream/main: [skip ci] Updated translations via Crowdin Check for valid user token in integration tests (go-gitea#21520) Ignore error when retrieving changed PR review files (go-gitea#21487) move invite by mail to services package (go-gitea#21513) Enable Monaco automaticLayout (go-gitea#21515) Update macOS install command (go-gitea#21507) [skip ci] Updated translations via Crowdin Suppress `ExternalLoginUserNotExist` error (go-gitea#21504) Revert increased width on pull pages (go-gitea#21470) Add team member invite by email (go-gitea#20307) Disable the 'Add File' button when not able to edit repo (go-gitea#21503) Remove vitest globals (go-gitea#21505) Fix branch dropdown shifting on page load (go-gitea#21428)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the button would render a dropdown with zero items when
.CanEnableEditorwas false (for example on a mirror repo). Now it disables the button instead which is better UX.