Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w)

[delvh]

Found using
find . -type f -name '*.go' -print -exec vim {} -c ':%s/fmt\.Errorf(\(.*\)%v\(.*\)err/fmt.Errorf(\1%w\2err/g' -c ':wq' \;

[silverwind]

IIRC, golangci-lint may have a linter to detect this. Not sure I find it now.

[delvh]

Agreed. But please only once this PR is merged.
In the next few minutes, a force-push will come that takes care of handling multiple errors and no error at all.
(force-push as I won't revert the commit simply to run the other search, and instead use the state before the commit)
Surprisingly, I seem to have a found a simple regex that also takes care of the edge cases I know of.

[zeripath]

Oh gods there are some delightfully unenlightening error messages there.

@wxiaoguang I think you're right we're just going to have to go down the route of adding the stack trace to these.

[delvh]

What exactly do you mean?

[silverwind]

Found the linter: https://github.com/polyfloyd/go-errorlint

You can just add errorlint to .golangci.yml after all errors are fixed and the linter will ensure no new issues arise. I'd do it in this PR.

[zeripath]

@delvh not really related to this PR but look at some of the errors reported, e.g. in notification.go:loadRepo(...):

	if n.Repository == nil {
		n.Repository, err = repo_model.GetRepositoryByIDCtx(ctx, n.RepoID)
		if err != nil {
			return fmt.Errorf("getRepositoryByID [%d]: %w", n.RepoID, err) // <- BUT WHY WAS I TRYING TO GET THIS?
		}
	}

If we think about this message a bit more - The error that GetRepositoryByIDCtx should return should already be GetRepositoryByIDCtx[%d]: %w and we shouldn't have to be adding that here. The error returned by this function should be adding the context that it's from loadRepo().

We're just adding the wrong context and doing so at every level.

I should add that at least this error is giving the context of the RepoID that is failing to be got from the DB. Many don't even provide that kind of information, e.g.:

// DeleteGPGKey deletes GPG key information in database.
func DeleteGPGKey(doer *user_model.User, id int64) (err error) {
	key, err := GetGPGKeyByID(id)
	if err != nil {
		if IsErrGPGKeyNotExist(err) {
			return nil
		}
		return fmt.Errorf("GetPublicKeyByID: %w", err) // WHICH BLOODY KEY?
	}

[6543]

I did test errorlint enabled and it catched a lot of good issues ... - but to many to enable it within this pull

[6543]

as comment

[zeripath]

 ❯ git diff main  | grep '%w.*%w'                                                             [19:44:36]
+						return fmt.Errorf("unable to check webauthn_credential[lower_name: %s, user_id:%w]. Error: %w", remigrated.LowerName, remigrated.UserID, err)
+			return fmt.Errorf("failed to rollback directory change during failed username change from: %s to: %s. DB Error: %w. Filesystem Error: %w", oldUserName, newUserName, err, err2)
+				err = fmt.Errorf("%w %w", err2, err)
+			return fmt.Errorf("%w other names: %w", err, l.MultiChannelledLog.GetEventLoggerNames())

[wxiaoguang]

Generally L-G-T-M.

CI failures are related, golangci-lint does very good job and catches mismatched formatting arguments.

[zeripath]

There was an incorrect whitespace change in blame_test.go.

[delvh]

What happened to the CI?
Why are there no longer any CI icons?