Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use right syntax for symbolic-ref command #21577

Merged
merged 10 commits into from
Oct 28, 2022
Merged

Use right syntax for symbolic-ref command #21577

merged 10 commits into from
Oct 28, 2022

Conversation

clarfonthey
Copy link
Contributor

Follow-up to #21352: when testing this out, I found out that the syntax for the symbolic-ref command was different than originally assumed in that PR. Never got around to submitting a PR until now.

@silverwind
Copy link
Member

Seems like git actually refuses if second argument does not start with refs/ so this couldn't have worked before, right?

$ git symbolic-ref HEAD main
fatal: Refusing to point HEAD outside of refs/

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 24, 2022
@silverwind
Copy link
Member

Also, please run make fmt.

@clarfonthey
Copy link
Contributor Author

Huh, wasn't aware that the default formatting didn't like spaces between plus signs. Anyway, fixed.

You're right that it wouldn't have worked before. I was actually hoping to test more before the original change was merged, and didn't voice so because I wasn't expecting it to get merged so quickly. This is mostly the result of said testing.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 24, 2022
@silverwind
Copy link
Member

Huh, wasn't aware that the default formatting didn't like spaces between plus signs.

It's one of the ideocracies of go fmt. Sometimes it wants spaces around +, sometimes it doesn't. I have not figured out what the rules around that are.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 25, 2022
@Gusted Gusted added this to the 1.18.0 milestone Oct 25, 2022
@Gusted Gusted added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 25, 2022
wxiaoguang
wxiaoguang reviewed Oct 26, 2022
View reviewed changes
modules/doctor/heads.go Outdated Show resolved Hide resolved
@lunny lunny modified the milestones: 1.18.0, 1.19.0 Oct 26, 2022
@techknowlogick techknowlogick merged commit 76e9a4f into go-gitea:main Oct 28, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 28, 2022
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
a4797b4 
* giteaoffical/main:
  fix: PR status layout on mobile (go-gitea#21547)
  Make rss/atom identifier globally unique (go-gitea#21550)
  Fix UI column width, button overflow Fomantic's grid (go-gitea#21559)
  Localize time units on activity heatmap (go-gitea#21570)
  Use right syntax for symbolic-ref command (go-gitea#21577)
  Update JS dependencies and misc tweaks (go-gitea#21583)
  Add index for hook_task table (go-gitea#21545)
  Revert: auto generate INTERNAL_TOKEN (go-gitea#21608)
@clarfonthey
Copy link
Contributor Author

Is this going to make it into 1.18, or should I submit a backport? Since the original change will be in 1.18.

@clarfonthey clarfonthey deleted the heads branch November 3, 2022 01:30
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@silverwind silverwind silverwind approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@clarfonthey @silverwind @wxiaoguang @yardenshoham @lunny @techknowlogick @GiteaBot @Gusted