Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionUser protection against nil pointer dereference #21581

Merged
merged 3 commits into from
Oct 24, 2022
Merged

SessionUser protection against nil pointer dereference #21581

merged 3 commits into from
Oct 24, 2022

Commits on Oct 6, 2022

  1. SessionUser protection against nil pointer dereference 

    `SessionUser` should be protected against passing `sess` = `nil` to avoid.

```
PANIC: runtime error: invalid memory address or nil pointer dereference
```

in

https://github.com/go-gitea/gitea/pull/18452/files#diff-a215b82aadeb8b4c4632fcf31215dd421f804eb1c0137ec6721b980136e4442aR69

after upgrade from gitea v1.16 to v1.17.

Related: go-gitea#18452
Author-Change-Id: IB#1126459
    @pboguslawski
    pboguslawski committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    adac68d View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Verification moved to correct method 

    Fixes: adac68d
Related: go-gitea#21358
Related: go-gitea#18452
Author-Change-Id: IB#1126459
    @pboguslawski
    pboguslawski committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    09628bb View commit details
    Browse the repository at this point in the history

  2. Update session.go

    @pboguslawski
    pboguslawski committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    33b6cf2 View commit details
    Browse the repository at this point in the history