Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick fixes monaco-editor error: "vs.editor.nullLanguage" #21734

Merged
merged 3 commits into from Nov 9, 2022
Merged

Quick fixes monaco-editor error: "vs.editor.nullLanguage" #21734

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cea7458
Quick fixes monaco-editor error: "vs.editor.nullLanguage"
Nov 9, 2022
09a3ab5
lint
Nov 9, 2022
f756972
Merge branch 'main' into bugfix/fix-monaco-editor-2962
lunny Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions web_src/js/bootstrap.js
View file
Open in desktop
Expand Up @@ -26,9 +26,6 @@ function processWindowErrorEvent(e) {
return; // ignore such nonsense error event
}

// Wait for upstream fix: https://github.com/microsoft/monaco-editor/issues/2962
if (e.message.includes('Language id "vs.editor.nullLanguage" is not configured nor known')) return;

showGlobalErrorMessage(`JavaScript error: ${e.message} (${e.filename} @ ${e.lineno}:${e.colno}). Open browser console to see more details.`);
}

Expand Down
4 changes: 4 additions & 0 deletions web_src/js/features/codeeditor.js
View file
Open in desktop
Expand Up @@ -99,6 +99,10 @@ export async function createMonaco(textarea, filename, editorOpts) {
}
});

// Quick fix: https://github.com/microsoft/monaco-editor/issues/2962
monaco.languages.register({id: 'vs.editor.nullLanguage'});
monaco.languages.setLanguageConfiguration('vs.editor.nullLanguage', {});

const editor = monaco.editor.create(container, {
value: textarea.value,
theme: 'gitea',
Expand Down