Add option to prohibit fork if user reached maximum limit of repositories

[ghost]

If user has reached the maximum limit of repositories:

• Before
  • disallow create
  • allow fork without limit
• This patch:
  • disallow create
  • disallow fork
  • Add option ALLOW_FORK_WITHOUT_MAXIMUM_LIMIT (Default true) : enable this allow user fork repositories without maximum number limit

fixed #21847

Signed-off-by: Xinyu Zhou i@sourcehut.net

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (main@c144942). Click here to learn what that means.
The diff coverage is 41.17%.

@@           Coverage Diff           @@
##             main   #21848   +/-   ##
=======================================
  Coverage        ?   48.23%           
=======================================
  Files           ?     1031           
  Lines           ?   140862           
  Branches        ?        0           
=======================================
  Hits            ?    67948           
  Misses          ?    64796           
  Partials        ?     8118           

Impacted Files	Coverage Δ
routers/api/v1/repo/fork.go	38.46% <0.00%> (ø)
services/repository/fork.go	36.87% <16.66%> (ø)
routers/web/repo/pull.go	30.77% <60.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[6543]

could you add a test to cover it?

[jolheiser]

What about instances where an admin wants to allow users to fork, but not create? I believe that is why this was never done in the past.

[techknowlogick]

@jolheiser on various instances we see people fork repos, but then nuke all the branches and go from there to bypass repo limits.

[jolheiser]

@jolheiser on various instances we see people fork repos, but then nuke all the branches and go from there to bypass repo limits.

Yeah, I also recall this being the argument made for it.
I guess this would come down to how an instance is managed.

In a (semi-)public instance, bypassing the repo limit by using forks would indeed be a problem.

In a more tightly controlled instance with fewer users, I would imagine this would be less of a problem depending on the context in which it's used.

---

What I'm wondering is if there's a better way to tackle the core problem.
I'm not necessarily for or against this PR, just wanted to lay out context on how it was discussed prior.

[ghost]

I think this patch should clarify this limit . Then introduce a configurable option in another patch, allow fork-only user.

[delvh]

I see this as follows:
Either we disallow forks completely once a user has {limit} repos,
or we add a new config, i.e. FORKS_COUNT_TO_REPO_LIMIT, to configure this behavior.
That are the only two options, because the current state violates its guarantee.

[lunny]

Please clarify or summary what's about the new proposal.

[ghost]

Summary:

If user has reached the maximum limit of repositories

• Before
  • disallow create
  • allow fork without limit
• This patch:
  • disallow create
  • disallow fork
  • CanForkRepo is alias of CanCreateRepo

proposal: If want to add the fork-only feature, modify the function CanForkRepo()

[lunny]

Summary:

If user has reached the maximum limit of repositories

• Before

  • disallow create
  • allow fork without limit

• This patch:

  • disallow create
  • disallow fork
  • CanForkRepo is alias of CanCreateRepo

proposal: If want to add the fork-only feature, modify the function CanForkRepo()

So how could you implement to allow fork but not allow create new repositories? I think a standalone limitation for fork repositories is better.

[ghost]

Summary:
If user has reached the maximum limit of repositories

• Before

  • disallow create
  • allow fork without limit

• This patch:

  • disallow create
  • disallow fork
  • CanForkRepo is alias of CanCreateRepo

proposal: If want to add the fork-only feature, modify the function CanForkRepo()

So how could you implement to allow fork but not allow create new repositories? I think a standalone limitation for fork repositories is better.

Add option ALLOW_FORK_WITHOUT_MAXIMUM_LIMIT (Default false)

If enable this option, same behavior as current
allow user fork repositories without maximum number limit

[zeripath]

This will be BREAKING by having the default be false.

It could actually be extremely breaking - I think we can't merge it like this.

[jolheiser]

🎺 🤖