Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown anchor re-clicking (#21931) #21946

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 26, 2022

Backport #21931. The hashchange event did not fire on re-click of a active anchor. Instead, use the click event which always fires.

Fixes: #21680

The hashchange event did not fire on re-click of a active anchor.
Instead, use the click event which always fires.

Fixes: go-gitea#21680

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: zeripath <art27@cantab.net>
@silverwind silverwind added this to the 1.18.0 milestone Nov 26, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 26, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 26, 2022
@lunny lunny merged commit cddceb9 into go-gitea:release/v1.18 Nov 26, 2022
@silverwind silverwind deleted the backport-21931 branch November 27, 2022 11:54
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants