Make gitea work using cmd.exe again #22073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gitea will attempt to lookup its location using LookPath however, this fails on cmd.exe if gitea is in the current working directory. exec.LookPath will return an exec.ErrDot error which we can test for and then simply using filepath.Abs(os.Args[0]) to absolute gitea against the current working directory. Fix go-gitea#22063 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
outdated/backport/v1.18
delvh
approved these changes
Dec 8, 2022
GiteaBot
added
the
lgtm/need 1
jolheiser
approved these changes
Dec 8, 2022
GiteaBot
added
lgtm/done
|
|
delvh
added
lgtm/need 1
lafriks
approved these changes
Dec 9, 2022
Signed-off-by: Andrew Thornton <art27@cantab.net>
delvh
approved these changes
Dec 13, 2022
lunny
added
reviewed/wait-merge
|
ping lg-tm |
|
Please send backport to v1.18 |
lunny
removed
the
reviewed/wait-merge
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Dec 14, 2022
Backport go-gitea#22073 Gitea will attempt to lookup its location using LookPath however, this fails on cmd.exe if gitea is in the current working directory. exec.LookPath will return an exec.ErrDot error which we can test for and then simply using filepath.Abs(os.Args[0]) to absolute gitea against the current working directory. Fix go-gitea#22063 Signed-off-by: Andrew Thornton <art27@cantab.net>
jolheiser
pushed a commit
that referenced
this pull request
Dec 14, 2022
Backport #22073 Gitea will attempt to lookup its location using LookPath however, this fails on cmd.exe if gitea is in the current working directory. exec.LookPath will return an exec.ErrDot error which we can test for and then simply using filepath.Abs(os.Args[0]) to absolute gitea against the current working directory. Fix #22063 Signed-off-by: Andrew Thornton <art27@cantab.net>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 15, 2022
* upstream/main: Fixed Project view .board-column height for tall screens. (go-gitea#22108) Correctly handle moved files in apply patch (go-gitea#22118) remove duplicated read file code (go-gitea#22042) Fix condition for is_internal (go-gitea#22095) Make gitea work using cmd.exe again (go-gitea#22073) Fix markdown typo of an extra backtick in docs (go-gitea#22123) Fix autofilled text visibility in dark mode (go-gitea#22088)
yardenshoham
added a commit
to yardenshoham/gitea
that referenced
this pull request
Feb 3, 2023
This was meant to land in go-gitea#22073 but was blocked until go-gitea#22732 was merged Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitea will attempt to lookup its location using LookPath however, this fails on cmd.exe if gitea is in the current working directory.
exec.LookPath will return an exec.ErrDot error which we can test for and then simply using filepath.Abs(os.Args[0]) to absolute gitea against the current working directory.
Fix #22063
Signed-off-by: Andrew Thornton art27@cantab.net