Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misc whitespace issues in install docs #22189

Merged
merged 5 commits into from
Dec 20, 2022

Conversation

h3xx
Copy link
Contributor

@h3xx h3xx commented Dec 20, 2022

I ran into issues when copy-pasting the docker-compose.yml contents from https://docs.gitea.io/en-us/install-with-docker/ - specifically the part about adding PostgreSQL to the YAML file; I tried manually adding the diffs by removing the + at the beginning of lines, and the resulting YAML was unparsable.

This forces the indentation to be consistent across all places where YAML is used.

Unnecessary; goes with what .editorconfig states
Make format consistent with with-docker-rootless.en-us.md.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 20, 2022
@silverwind silverwind added type/docs This PR mainly updates/creates documentation lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #22189 (9f5ebd8) into main (2774671) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #22189      +/-   ##
==========================================
+ Coverage   48.10%   48.11%   +0.01%     
==========================================
  Files        1043     1044       +1     
  Lines      142190   142329     +139     
==========================================
+ Hits        68397    68483      +86     
- Misses      65600    65664      +64     
+ Partials     8193     8182      -11     
Impacted Files Coverage Δ
modules/charset/charset.go 71.73% <0.00%> (-3.63%) ⬇️
models/unit/unit.go 47.00% <0.00%> (-1.71%) ⬇️
services/forms/user_form.go 44.00% <0.00%> (-1.37%) ⬇️
services/pull/pull.go 41.24% <0.00%> (-0.47%) ⬇️
models/organization/org.go 70.99% <0.00%> (-0.14%) ⬇️
routers/web/repo/setting.go 16.44% <0.00%> (-0.13%) ⬇️
routers/web/org/setting.go 0.00% <0.00%> (ø)
modules/timeutil/timestamp.go 100.00% <0.00%> (ø)
models/secret/secret.go 24.56% <0.00%> (ø)
models/repo.go 49.78% <0.00%> (+0.10%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 20, 2022
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Dec 20, 2022
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 20, 2022
@techknowlogick techknowlogick merged commit 70d15e7 into go-gitea:main Dec 20, 2022
@techknowlogick techknowlogick removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 20, 2022
@h3xx h3xx deleted the doc-indent branch December 21, 2022 15:42
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 23, 2022
* giteaoffical/main: (32 commits)
  Hide file borders on sticky diff box (go-gitea#22217)
  Test views of LFS files (go-gitea#22196)
  update docs latest to 1.17.4
  Frontport 1.17.4 changelog (go-gitea#22216)
  Remove test session cache to reduce possible concurrent problem (go-gitea#22199)
  Upgrade hugo to 0.82 (go-gitea#22209)
  Fix container layer display overflow (go-gitea#22208)
  Run hugo via `go run` and lock its version (go-gitea#22206)
  Update bleve and zapx to fix unaligned atomic (go-gitea#22031)
  Allow empty assignees on pull request edit (go-gitea#22150)
  Add Feed for Releases and Tags (go-gitea#21696)
  fix: update libcurl in docs pipeline (go-gitea#22203)
  Fixed colour transparency regex matching in project board sorting (go-gitea#22091) (go-gitea#22092)
  Mobile fix for Project view: Add delay to Sortable.js on mobile, to ensure scrolling is possible. (go-gitea#22152)
  Normalize NuGet package version on upload (go-gitea#22186)
  Attempt to fix TestExportUserGPGKeys (go-gitea#22159)
  Specify ID in `TestAPITeam` (go-gitea#22192)
  Repair LFS web rendering. (go-gitea#22195)
  Fix misc whitespace issues in install docs (go-gitea#22189)
  Update JS dependencies and eslint (go-gitea#22190)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants