improve testing for pgsql empty repository

[lunny]

sometimes ci failure https://drone.gitea.io/go-gitea/gitea/64840/3/8
This PR is to know what happened.

[wxiaoguang]

I do not think this PR makes sense. Actually, it should already be clear about what happened:

[E] [63a47c93] Repository 34:user21/golang has a broken repository on the file system: 
/tmp/tmp.zA74IwWOdz/tests/integration/gitea-integration-pgsql/gitea-repositories/user21/golang.git 
Error: no such file or directory

My guess is that the test code of TestEmptyRepo is not stable.

	emptyRepo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{}, unittest.Cond("is_empty = ?", true))
	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: emptyRepo.OwnerID})

The query WHERE is_emtpy=true is not stable, it may return different results (it depends on database's behavior)

If the returned repo & user have valid git repo on filesystem, then the test passes (most time).

But, if something like user21's repo is returned, since it doesn't have any valid git repo on filesystem, the test fails.

[lunny]

I do not think this PR makes sense. Actually, it should already be clear about what happened:

[E] [63a47c93] Repository 34:user21/golang has a broken repository on the file system: 
/tmp/tmp.zA74IwWOdz/tests/integration/gitea-integration-pgsql/gitea-repositories/user21/golang.git 
Error: no such file or directory

My guess is that the test code of TestEmptyRepo is not stable.

	emptyRepo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{}, unittest.Cond("is_empty = ?", true))
	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: emptyRepo.OwnerID})

The query WHERE is_emtpy=true is not stable, it may return different results (it depends on database's behavior)

If the returned repo & user have valid git repo on filesystem, then the test passes (most time).

But, if something like user21's repo is returned, since it doesn't have any valid git repo on filesystem, the test fails.

I do not think this PR makes sense. Actually, it should already be clear about what happened:

[E] [63a47c93] Repository 34:user21/golang has a broken repository on the file system: 
/tmp/tmp.zA74IwWOdz/tests/integration/gitea-integration-pgsql/gitea-repositories/user21/golang.git 
Error: no such file or directory

My guess is that the test code of TestEmptyRepo is not stable.

	emptyRepo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{}, unittest.Cond("is_empty = ?", true))
	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: emptyRepo.OwnerID})

The query WHERE is_emtpy=true is not stable, it may return different results (it depends on database's behavior)

If the returned repo & user have valid git repo on filesystem, then the test passes (most time).

But, if something like user21's repo is returned, since it doesn't have any valid git repo on filesystem, the test fails.

Thanks! Done.

[wxiaoguang]

LGTM, while it may be easier to just use WHERE id=xxx to query an empty repo explicitly.

[KN4CK3R]

While looking at the code I thought the same as @wxiaoguang , why not use a specific repo which meets the conditions?

[lunny]

@KN4CK3R @wxiaoguang done.