Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure webhook module #22256

Merged
merged 25 commits into from
Jan 1, 2023
Merged

Restructure webhook module #22256

merged 25 commits into from
Jan 1, 2023

Commits on Dec 27, 2022

  1. Remove "import services" for webhook module 

    Previously, there was an "import services/webhooks" inside
"modules/notification/webhook".
This import was removed (after fighting against many import cycles).
Additionally, a few constants were extracted from "models/webhooks" to
"modules/notification/webhook".
    @delvh
    delvh committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    4f4104a View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2022

  1. Run formatter

    @delvh
    delvh committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    39b8b27 View commit details
    Browse the repository at this point in the history

  2. Fix oversights

    @delvh
    delvh committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    3a2d64d View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @delvh
    delvh committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    a669ba4 View commit details
    Browse the repository at this point in the history

  4. … and the remaining test as well as the formatter again

    @delvh
    delvh committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    16cc5a5 View commit details
    Browse the repository at this point in the history

  5. mv modules/notification/webhook -> modules/webhook

    @delvh
    delvh committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    44e1ffe View commit details
    Browse the repository at this point in the history

  6. Change import also in missed tests

    @delvh
    delvh committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    bfa2c35 View commit details
    Browse the repository at this point in the history

  7. Format again

    @delvh
    delvh committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    e43911d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into maintenance/move-webhook-type-to-modules

    @6543
    6543 committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    d0244b8 View commit details
    Browse the repository at this point in the history

  9. Remove tags file from gitignore

    @delvh
    delvh committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    a3401d5 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2022

  1. Move webhook errors back to models

    @delvh
    delvh committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    529b532 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into maintenance/move-webhook-type-to-modules 

    Additionally fix another import cycle that occurred due to the merge
    @delvh
    delvh committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    17b33d2 View commit details
    Browse the repository at this point in the history

  3. Run formatter… again

    @delvh
    delvh committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    ae85520 View commit details
    Browse the repository at this point in the history

  4. Move Webhook status constants also to modules

    @delvh
    delvh committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    40c7cde View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into maintenance/move-webhook-type-to-modules

    @delvh
    delvh committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    66882ea View commit details
    Browse the repository at this point in the history

  6. Fix tests

    @delvh
    delvh committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    0fc541b View commit details
    Browse the repository at this point in the history

  7. Remove comment as the linter complains about it

    @delvh
    delvh committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    927b08f View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2022

  1. Remove dependence of migration v233 on a custom type

    @delvh
    delvh committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    9964308 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2022

  1. Merge branch 'main' into maintenance/move-webhook-type-to-modules

    @lunny
    lunny committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    469ea8d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into maintenance/move-webhook-type-to-modules

    @delvh
    delvh committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    e17b383 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2023

  1. Merge branch 'main' into maintenance/move-webhook-type-to-modules

    @lunny
    lunny committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    8bb9921 View commit details
    Browse the repository at this point in the history

  2. Move ToHook to ../webhook to prevent an import cycle and a new package 

    as per @lunny
    @delvh
    delvh committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    db7db12 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into maintenance/move-webhook-type-to-modules

    @lunny
    lunny committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    5cc5cb0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into maintenance/move-webhook-type-to-modules

    @lunny
    lunny committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    1be6ff0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into maintenance/move-webhook-type-to-modules

    @lunny
    lunny committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    72098fd View commit details
    Browse the repository at this point in the history