Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File path tweaks in UI #2264

Merged
merged 1 commit into from
Aug 6, 2017
Merged

File path tweaks in UI #2264

merged 1 commit into from
Aug 6, 2017

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Aug 5, 2017 •
edited
Loading

  • Adjust file path to wrap at 30 chars instead of 25/15.
  • Allow text selection of path. No idea why Semantic UI blocks selection on those, so I overrode it.
  • Turn a few <div>s into <span>s so that copied text from the path does not include newlines.

Before

After

@appleboy appleboy added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Aug 5, 2017
@appleboy appleboy added this to the 1.2.0 milestone Aug 5, 2017
@Bwko
Copy link
Member

Bwko commented Aug 5, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 5, 2017
@lafriks
Copy link
Member

lafriks commented Aug 5, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 5, 2017
@appleboy appleboy merged commit 54381f4 into go-gitea:master Aug 6, 2017
@silverwind silverwind deleted the path-ellipsis branch August 6, 2017 05:36
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @Bwko @lafriks @appleboy @tboerger