Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links for the menus in the view file page #22795

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Fix links for the menus in the view file page #22795

merged 3 commits into from
Feb 7, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Feb 7, 2023 •
edited
Loading

Follow #21986

  • Fix the "Reference in New Issue" menu, it won't be affected by HTMLURL and the code is clearer.
  • Fix the "Copy Permlink" menu, it needs to copy absolute URL
  • Clearly define the behavior of toAbsoluteUrl

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 7, 2023
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 7, 2023
delvh
delvh reviewed Feb 7, 2023
View reviewed changes
web_src/js/utils.js Show resolved Hide resolved
web_src/js/features/repo-code.js Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 7, 2023
@lunny lunny merged commit 2c6cc0b into go-gitea:main Feb 7, 2023
@wxiaoguang wxiaoguang deleted the fix-abs-url-bug branch February 7, 2023 16:16
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 9, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
563b414 
* upstream/main:
  change org_type.go to visible_type.go and fix the notes (go-gitea#22752)
  Improve notification and stopwatch styles (go-gitea#22169)
  Fix blame view missing lines (go-gitea#22826)
  Load issue before accessing index in merge message (go-gitea#22822)
  include build info in Prometheus metrics (go-gitea#22819)
  Fix rerun button of Actions (go-gitea#22798)
  Map OIDC groups to Orgs/Teams (go-gitea#21441)
  Fix links for the menus in the view file page (go-gitea#22795)
@wxiaoguang wxiaoguang mentioned this pull request Feb 9, 2023
Merged
techknowlogick pushed a commit that referenced this pull request Feb 9, 2023
@wxiaoguang
Improve AppUrl/ROOT_URL checking (#22836)
cef8f50 
After some PRs:
* #21986
* #22795
* #22808
* #22831
* #22839

Users won't be affected by the ROOT_URL problem in most cases. Close
#19345

This PR improves AppUrl/ROOT_URL checking, only check it on the admin
page, and the message is also updated.

Feel free to suggest about more English-native messages.



![image](https://user-images.githubusercontent.com/2114189/217811809-7d44ddb7-2c4a-46d0-a5db-8ae6ee65f8c3.png)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wxiaoguang @lunny @delvh @GiteaBot