Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid issues in project boards #22865

Draft
wants to merge 95 commits into
base: main
Choose a base branch
from
Draft

Fix invalid issues in project boards #22865

wants to merge 95 commits into from
+365 −69

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Feb 11, 2023 •
edited
Loading

Fixes #22860

Latest Edit: 2023/04/26)

Fixed:

  1. Fix TODO in func addUpdateIssueProject. (Which will make user project unselectable in a issue)
  2. Permission check in the Projectboard.

Todo in future:

  1. Select multi projects in a issue (If it is necessary)
  2. New Issue button in a usertype project (related to Organization-wide issues #23827)
  3. project search in user project list
  4. Fix invalid issues in project boards #22865 (comment)

@yp05327 yp05327 mentioned this pull request Feb 11, 2023
Open
@yp05327
Copy link
Contributor Author

yp05327 commented Feb 11, 2023

There are still some bugs now. I will fix them later.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 11, 2023
yp05327 and others added 3 commits February 12, 2023 03:08
@yp05327
fix
91cbfce
@zeripath
fix lint
3f76a8f 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@yp05327
improve edit/close/delete permission
192a6d4
@lunny lunny added topic/ui Change the appearance of the Gitea UI type/bug labels Feb 12, 2023
@lunny lunny added this to the 1.19.0 milestone Feb 12, 2023
@yp05327 yp05327 changed the title Fix edit/close/delete projects of user/org Fix edit/close/delete projects and the permisson control Feb 12, 2023
@yp05327 yp05327 mentioned this pull request Feb 12, 2023
Merged
@yp05327
Copy link
Contributor Author

yp05327 commented Feb 12, 2023

It seems that it works well now.
I don't know whether there are some same bugs in packages page, since I don't know how to use it.

@yp05327
Copy link
Contributor Author

yp05327 commented Feb 14, 2023 •
edited
Loading

New bugs:
4. the projectlist in issue create page need to show the type of this project.
If an org project's name is as same as a repo project it is hard to know which project to choose.
image
5. create an issue which links to an org project will redirect to 404 page
↓
Fixed
6. no New Issue button in org project page

@yp05327
Copy link
Contributor Author

yp05327 commented Feb 14, 2023

I made an mistake, it is necessary to check issue and pull request permission, not only projects permission.

lunny
lunny reviewed Feb 14, 2023
View reviewed changes
models/project/project.go Outdated Show resolved Hide resolved
@yp05327
remove TypeUser
f92c5e0 
improve project names and icons in create/view/list issue page
improve project names in issue badge
redirect to origin page after edit an project
@yp05327 yp05327 changed the title Fix edit/close/delete projects and the permisson control Fix org/user projects bugs and imporve usability Feb 15, 2023
@delvh delvh removed this from the 1.20.0 milestone Jun 7, 2023
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 3, 2023
@timmwille
Copy link

I'm not sure if this is solved via this PR already but please check out this important related comment (privacy critical bug):
#22860 (comment)

@timmwille
Copy link

Ok, seams like this might still be an open task/bug to fix if I read this comment right:
https://codeberg.org/forgejo/forgejo/issues/750#issuecomment-917424

@6543 6543 removed the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Feb 25, 2024
@6543
Copy link
Member

6543 commented Feb 25, 2024

Is there a chance to have the conlficts fixed?

@yp05327
Copy link
Contributor Author

yp05327 commented Mar 6, 2024

I will try to, but I'm afraid maybe almost all of them are fixed.

@6543 6543 requested a review from lunny March 6, 2024 08:17
@6543 6543 added this to the 1.22.0 milestone Mar 6, 2024
@yp05327
Copy link
Contributor Author

yp05327 commented Mar 6, 2024

Need to check it carefully, as almost all changes are almost one year ago.

@yp05327 yp05327 marked this pull request as draft March 6, 2024 09:02
@yp05327 yp05327 mentioned this pull request Mar 7, 2024
Draft
@yp05327
Copy link
Contributor Author

yp05327 commented Mar 7, 2024

Reviewed this PR again, and I think this PR can be two.

  1. incorrect permission check when listing issues in project board
    Add permission check to LoadIssuesFromBoard #29643 can fix it.
  2. incorrect permission check when linking projects in issues sidebar
    I'm not sure whether doer need write permission for project unit when assign an issue to a project.
    The current solution is that doer need it.
    Maybe this can be simplifier by only one DB query, but we need to do more works to project search option.

@lunny lunny modified the milestones: 1.22.0, 1.23.0 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@6543 6543 6543 approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees
No one assigned
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Fix bugs in org/user level projects