Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a
.diff-file-box
ingitea/web_src/less/_repository.less
Line 1706 in be93e48
And the
border-radius
doesn't look necessary, or it should be fine tuned on.diff-file-box:target
. On your screenshot, the bottom border corners are still right angles.Screenshot:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_repository.less
is a completely different file, and the selector you're speaking about is nested. While we can use it, I'm not a fan of nested selectors as they make the outcome so difficult to predict. Additionally,_review
should be loaded less often than_repository
and only when needed.border-radius
is needed as thediff-file-header
sets theborder-radius: 0.285rem
(ui.top.attached.header
). Otherwise, it looks like this:border-radius
into:target
, but why?Why should it change its boundaries only when targeted?
Fomantic UI
forcefully sets theborder-radius:0
for the table, and I haven't found any solution yet. At that point, I simply surrendered and I think the functional aspect of this enhancement is present. If anyone has any better ideas, please feel free to commit directly on this PR.