Fix the full-height problem for all pages #22905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 14, 2023
Merged
wolfogre
approved these changes
Feb 14, 2023
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Feb 14, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
LG-TM bot |
lunny
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 15, 2023
* upstream/main: Add command to bulk set must-change-password (go-gitea#22823) Remember to attach the parent tree when converting TreeEntry() -> Tree() (go-gitea#22902) Fix dark-colored description text in arc-green theme (go-gitea#22908) Fix the full-height problem for all pages (go-gitea#22905) Remove Fomantic-UI's `.hidden` CSS class for menu elements (go-gitea#22895)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really fix #22883, close #22901
I made a mistake that the global styles in RepoActionView.vue could still pollute global styles (I forgot that the code of this component is still loaded on every page, instead of loaded on demand)
This PR makes a complete fix: only change the page's full-height behavior if the component is used.
Screenshot after the fix: