Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no user listed in org teams page #22979

Merged
merged 2 commits into from
Feb 19, 2023
Merged

Fix no user listed in org teams page #22979

merged 2 commits into from
Feb 19, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Feb 19, 2023

#22294 introduced this bug.
Before:
picture
After:
picture

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 19, 2023
@lunny lunny added type/bug issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 19, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 19, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 19, 2023
@techknowlogick techknowlogick added this to the 1.19.0 milestone Feb 19, 2023
@techknowlogick techknowlogick added the outdated/backport/v1.18 This PR should be backported to Gitea 1.18 label Feb 19, 2023
@lunny lunny removed the outdated/backport/v1.18 This PR should be backported to Gitea 1.18 label Feb 19, 2023
@lunny lunny merged commit d5e417a into go-gitea:main Feb 19, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 19, 2023
@wxiaoguang wxiaoguang mentioned this pull request Feb 19, 2023
Merged
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 19, 2023 •
edited
Loading

The avatar function needs a default case to catch incorrect argument, panic or error log will help developers in the future to catch low-level mistakes as early as possible.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 20, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
049a04b 
* upstream/main:
  Fix broken pull request files (go-gitea#22962)
  Fix avatar misalignment (go-gitea#22955)
  Refactor the setting to make unit test easier (go-gitea#22405)
  Migration v244.go should be v243.go (go-gitea#22988)
  Adjust manifest to prevent tagging latest on rcs (go-gitea#22811)
  Add some guidelines for refactoring (go-gitea#22880)
  Rename `GetUnits` to `LoadUnits` (go-gitea#22970)
  Provide the ability to set password hash algorithm parameters (go-gitea#22942)
  Fix no user listed in org teams page (go-gitea#22979)
  Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (go-gitea#22950)
  Scoped labels (go-gitea#22585)
  Rename "People" to "Members" in organization page and use a better icon (go-gitea#22960)
  Rename `repo.GetOwner` to `repo.LoadOwner` (go-gitea#22967)
  Notify on container image create (go-gitea#22806)
  webview: Fix overflowing diff body (go-gitea#22959)
  Introduce customized HTML elements, fix incorrect AppUrl usages in templates (go-gitea#22861)
  Sort issues and pulls by recently updated in user and organization home (go-gitea#22925)
  Fix 404 error viewing the LFS file (go-gitea#22945)
@yp05327 yp05327 deleted the fix-no-user-listed-in-org-team-page branch February 21, 2023 02:45
@wxiaoguang wxiaoguang mentioned this pull request Apr 28, 2023
Closed
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@fuxiaohei fuxiaohei fuxiaohei approved these changes

Assignees
No one assigned
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yp05327 @wxiaoguang @lunny @fuxiaohei @techknowlogick @GiteaBot