Add wrapper to author to avoid long name ui problem (#23030) #23098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a possible solution for issue go-gitea#22866. Main change is to add a `author-wrapper` class around author name, like the wrapper added to message. The `max-width` is set to 200px on PC, and 100px on mobile device for now.
yardenshoham
added
type/bug
skip-changelog
jolheiser
approved these changes
Feb 23, 2023
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Feb 24, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #23030
This PR is a possible solution for issue #22866. Main change is to add a
author-wrapperclass around author name, like the wrapper added to message. Themax-widthis set to 200px on PC, and 100px on mobile device for now. Which will work like below:And
titleis added to the wrapper like it did in message wrapper. So the full author name will show on hover.