Fix DBConsistency checks on MSSQL (#23132) #23133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately xorm's `builder.Select(...).From(...)` does not escape the
table names. This is mostly not a problem but is a problem with the
`user` table.
This PR simply escapes the user table. No other uses of `From("user")`
where found in the codebase so I think this should be all that is
needed.
Fix go-gitea#23064
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
approved these changes
Feb 25, 2023
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Feb 25, 2023
GiteaBot
added
lgtm/done
delvh
approved these changes
Feb 25, 2023
|
This is a backport so you might want to comment this on the original PR |
|
That was already merged by the time I wrote this comment, hence I simply combined my review with this comment… |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #23132
Unfortunately xorm's
builder.Select(...).From(...)does not escape the table names. This is mostly not a problem but is a problem with theusertable.This PR simply escapes the user table. No other uses of
From("user")where found in the codebase so I think this should be all that is needed.Fix #23064