Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various bugs for "install" page (#23194) #23286

Merged
merged 2 commits into from
Mar 5, 2023

Commits on Mar 4, 2023

  1. Fix various bugs for "install" page (go-gitea#23194)

    ## TLDR
    
    * Fix the broken page / broken image problem when click "Install"
    * Close go-gitea#20089
    * Fix the Password Hash Algorithm display problem for go-gitea#22942
    * Close go-gitea#23183
    * Close go-gitea#23184
    
    ## Details
    
    ### The broken page / broken image problem when click "Install"
    (Redirect failed after install gitea go-gitea#23184)
    
    Before: when click "install", all new requests will fail, because the
    server has been restarted. Users just see a broken page with broken
    images, sometimes the server is not ready but the user would have been
    redirect to "/user/login" page, then the users see a new broken page
    (connection refused or something wrong ...)
    
    After: only check InstallLock=true for necessary handlers, and sleep for
    a while before restarting the server, then the browser has enough time
    to load the "post-install" page. And there is a script to check whether
    "/user/login" is ready, the user will only be redirected to the login
    page when the server is ready.
    
    ### During new instance setup make 'Gitea Base URL' filled from
    window.location.origin go-gitea#20089
    
    If the "app_url" input contains `localhost` (the default value from
    config), use current window's location href as the `app_url` (aka
    ROOT_URL)
    
    ### Fix the Password Hash Algorithm display problem for "Provide the
    ability to set password hash algorithm parameters go-gitea#22942"
    
    Before: the UI shows `pbkdf2$50000$50`
    
    <details>
    
    ![image](https://user-images.githubusercontent.com/2114189/221917143-e1e54798-1698-4fee-a18d-00c48081fc39.png)
    
    </details>
    
    After: the UI shows `pbkdf2`
    
    <details>
    
    ![image](https://user-images.githubusercontent.com/2114189/221916999-97a15be8-2ebb-4a01-bf93-dac18e354fcc.png)
    
    </details>
    
    ### GET data: net::ERR_INVALID_URL go-gitea#23183
    
    Cause by empty `data:` in `<link rel="manifest"
    href="data:{{.ManifestData}}">`
    
    ---------
    
    Co-authored-by: Jason Song <i@wolfogre.com>
    Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
    Co-authored-by: techknowlogick <techknowlogick@gitea.io>
    4 people authored and GiteaBot committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    1e25472 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. Configuration menu
    Copy the full SHA
    7114a53 View commit details
    Browse the repository at this point in the history