Use custom search for each filter type in dashboard #2343

Morlinest · 2017-08-20T13:14:10Z

Based on #2326 (need to be merged first)
Discussion on #2312

Fast network (no restrictions):

Slow network ("Slow 3G" through Chrome network setting):

Edit: Updated screnshots/gifs.

jonasfranz · 2017-08-21T18:53:44Z

models/repo_list.go

@@ -110,11 +110,37 @@ type SearchRepoOptions struct {
 	// maximum: setting.ExplorePagingNum
 	// in: query
 	PageSize int `json:"limit"` // Can be smaller than or equal to setting.ExplorePagingNum
+	// Type of repository to search
+	//
+	// in: query


Could you please run make generate-swagger to regenerate the swagger spec? This might resolve the conflict. If not please resolve the conflicts manually.

I did. Conflicts are new due to new master. I'll rebase and run it again.

jonasfranz · 2017-08-21T18:58:49Z

models/repo_list.go

 }

+// RepoType contains possible types of repository


Please add swagger:parameter like here: https://github.com/Morlinest/gitea/blob/aa6a2c996252707a1ada79c52661e1f464bccee9/models/repo_list.go#L92

jonasfranz · 2017-08-21T18:59:41Z

public/swagger.v1.json

@@ -232,6 +232,14 @@
            "description": "Limit of result\n\nmaximum: setting.ExplorePagingNum",
            "name": "limit",
            "in": "query"
+          },


Do not add swagger stuff manually because it will be overwritten if you run make generate-swagger.

Never touched this file manually. It was generated by make generate-swagger (exactly mingw32-make generate-swagger).

Morlinest · 2017-08-21T21:25:12Z

@JonasFranzDEV Please comment first 2 commits in #2326. This PR is based on it (master -> #2326 -> #2343).

codecov-io · 2017-09-16T15:01:17Z

Codecov Report

Merging #2343 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2343   +/-   ##
=======================================
  Coverage   26.84%   26.84%           
=======================================
  Files          89       89           
  Lines       17608    17608           
=======================================
  Hits         4727     4727           
  Misses      12195    12195           
  Partials      686      686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266ebf8...27a4890. Read the comment docs.

Morlinest · 2017-09-16T16:15:12Z

Rebased on top of #2371 + #2326. Only last commit is new.

Morlinest · 2017-10-26T21:53:26Z

PR reopened as all needed features were merged. Rebased on master, ready for testing, review and comments.

lafriks · 2017-10-26T22:05:16Z

@JonasFranzDEV please review again

Morlinest · 2017-11-01T15:32:54Z

@lafriks FYI he was actually reviewing another PR code (as this PR was not based on master). That code is not part of this PR anymore.

Morlinest · 2017-11-01T15:38:04Z

Changed UI by removing second loader that was causing "flickering" effect if search was fast. Now the repository counter is reset on each filter change. Adding new screenshots (limit set to 5 repositories for this tests).

Edit: Screenshots moved to PR description.

lunny · 2017-11-01T15:44:02Z

LGTM

lafriks · 2017-11-01T15:47:26Z

LGTM

lafriks · 2017-11-01T19:21:21Z

Make LG-TM work

lafriks · 2017-11-01T19:40:50Z

@JonasFranzDEV I hope you had no requested changes anymore. Just after merging noticed that you have not approved yet

Morlinest force-pushed the feature-dashboard-filters-custom-search branch from 4278a1b to aa6a2c9 Compare August 20, 2017 13:58

lafriks added type/bug type/enhancement An improvement of existing functionality and removed type/bug labels Aug 20, 2017

lafriks added this to the 1.x.x milestone Aug 20, 2017

jonasfranz suggested changes Aug 21, 2017

View reviewed changes

Morlinest force-pushed the feature-dashboard-filters-custom-search branch 2 times, most recently from 2f0a8a2 to 2b16b01 Compare August 21, 2017 21:19

tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 21, 2017

Morlinest mentioned this pull request Sep 6, 2017

Refactor searchRepositoryByName function and remove another redundant function #2371

Closed

Morlinest force-pushed the feature-dashboard-filters-custom-search branch 2 times, most recently from f1289e2 to 8cf8380 Compare September 16, 2017 14:01

Morlinest changed the title ~~Custom search for each filter in repo-search component~~ Use custom search for each filter type in dashboard Sep 16, 2017

Morlinest force-pushed the feature-dashboard-filters-custom-search branch from 8cf8380 to 9a7a5a0 Compare September 16, 2017 14:41

Morlinest force-pushed the feature-dashboard-filters-custom-search branch 3 times, most recently from c520dfc to 62655d8 Compare September 21, 2017 09:58

Morlinest closed this Sep 22, 2017

lunny removed this from the 1.x.x milestone Sep 24, 2017

Morlinest mentioned this pull request Oct 21, 2017

Add search mode option to /api/repo/search #2756

Merged

Morlinest reopened this Oct 26, 2017

Morlinest force-pushed the feature-dashboard-filters-custom-search branch 2 times, most recently from d96fd6a to dd7b4e5 Compare October 26, 2017 21:51

Morlinest added 2 commits November 1, 2017 16:29

Do custom search for each filter in repo-search

7d007f5

Fix search url

6757740

Morlinest added 2 commits November 1, 2017 16:29

Simplify code

5544b39

Remove loader and reset counts when changing filter

86a07f8

Morlinest force-pushed the feature-dashboard-filters-custom-search branch from c2d1538 to 86a07f8 Compare November 1, 2017 15:29

lunny added this to the 1.3.0 milestone Nov 1, 2017

tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 1, 2017

tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 1, 2017

Merge branch 'master' into feature-dashboard-filters-custom-search

27a4890

lafriks merged commit 25acd6c into go-gitea:master Nov 1, 2017

Morlinest deleted the feature-dashboard-filters-custom-search branch November 1, 2017 19:39

Morlinest mentioned this pull request Nov 4, 2017

Add number of repos for every filter type #2312

Closed

go-gitea locked and limited conversation to collaborators Nov 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use custom search for each filter type in dashboard #2343

Use custom search for each filter type in dashboard #2343

Morlinest commented Aug 20, 2017 •

edited

Loading

jonasfranz Aug 21, 2017

Morlinest Aug 21, 2017

jonasfranz Aug 21, 2017

Morlinest Aug 21, 2017

jonasfranz Aug 21, 2017

Morlinest Aug 21, 2017

Morlinest commented Aug 21, 2017

codecov-io commented Sep 16, 2017 •

edited

Loading

Morlinest commented Sep 16, 2017

Morlinest commented Oct 26, 2017

lafriks commented Oct 26, 2017

Morlinest commented Nov 1, 2017

Morlinest commented Nov 1, 2017 •

edited

Loading

lunny commented Nov 1, 2017

lafriks commented Nov 1, 2017

lafriks commented Nov 1, 2017

lafriks commented Nov 1, 2017

Use custom search for each filter type in dashboard #2343

Use custom search for each filter type in dashboard #2343

Conversation

Morlinest commented Aug 20, 2017 • edited Loading

jonasfranz Aug 21, 2017

Choose a reason for hiding this comment

Morlinest Aug 21, 2017

Choose a reason for hiding this comment

jonasfranz Aug 21, 2017

Choose a reason for hiding this comment

Morlinest Aug 21, 2017

Choose a reason for hiding this comment

jonasfranz Aug 21, 2017

Choose a reason for hiding this comment

Morlinest Aug 21, 2017

Choose a reason for hiding this comment

Morlinest commented Aug 21, 2017

codecov-io commented Sep 16, 2017 • edited Loading

Codecov Report

Morlinest commented Sep 16, 2017

Morlinest commented Oct 26, 2017

lafriks commented Oct 26, 2017

Morlinest commented Nov 1, 2017

Morlinest commented Nov 1, 2017 • edited Loading

lunny commented Nov 1, 2017

lafriks commented Nov 1, 2017

lafriks commented Nov 1, 2017

lafriks commented Nov 1, 2017

Morlinest commented Aug 20, 2017 •

edited

Loading

codecov-io commented Sep 16, 2017 •

edited

Loading

Morlinest commented Nov 1, 2017 •

edited

Loading