Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile page email display, respect settings (#23747) #23756

Merged
merged 1 commit into from Mar 27, 2023

Commits on Mar 27, 2023

  1. Fix profile page email display, respect settings (go-gitea#23747)

    Always respect the `setting.UI.ShowUserEmail` and `KeepEmailPrivate`
    setting.
    
    * It doesn't make sense to show user's own E-mail to themself.
    * Always hide the E-mail if KeepEmailPrivate=true, then the user could
    know how their profile page looks like for others.
    * Revert the `setting.UI.ShowUserEmail` change from go-gitea#4981 . This setting
    is used to control the E-mail display, not only for the user list page.
    
    ps: the incorrect `<div .../>` tag on the profile page has been fixed by
    go-gitea#23748 together, so this PR becomes simpler.
    wxiaoguang authored and GiteaBot committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    5e4fa3a View commit details
    Browse the repository at this point in the history