Clarify Translation Process. Also fix branch names #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have any idea about the rule on total % translated. I think to sync the translations before release the next version. LGTM |
tboerger
added
the
lgtm/need 2
appleboy
approved these changes
Aug 24, 2017
tboerger
added
lgtm/need 1
bkcsoft
commented
Aug 24, 2017
CONTRIBUTING.md
Outdated
| @@ -51,6 +52,10 @@ Pull requests should only include `vendor/` updates if they are part of the same | |||
|
|
|||
| The `vendor/` update needs to be justified as part of the PR description, and must be verified by the reviewers and/or merger to always reference an existing upstream commit. | |||
|
|
|||
| ## Translation | |||
|
|
|||
| We do all translation work inside [CrowdIn](https://crowdin.com/project/gitea). The only translation that is maintained in this git repository is [`en_US.ini`](https://github.com/go-gitea/gitea/blob/master/options/locale/locale_en-US.ini) and is synced regularily to CrowdIn. Once a translation has reached A SATISFACTORY PERCENTAGE it will be synced back into this repo and included in the next released version. | |||
There was a problem hiding this comment.
A SATISFACTORY PERCENTAGE should either be decided or changed 😉
ethantkoenig
suggested changes
Aug 24, 2017
CONTRIBUTING.md
Outdated
| @@ -51,6 +52,10 @@ Pull requests should only include `vendor/` updates if they are part of the same | |||
|
|
|||
| The `vendor/` update needs to be justified as part of the PR description, and must be verified by the reviewers and/or merger to always reference an existing upstream commit. | |||
|
|
|||
| ## Translation | |||
|
|
|||
| We do all translation work inside [CrowdIn](https://crowdin.com/project/gitea). The only translation that is maintained in this git repository is [`en_US.ini`](https://github.com/go-gitea/gitea/blob/master/options/locale/locale_en-US.ini) and is synced regularily to CrowdIn. Once a translation has reached A SATISFACTORY PERCENTAGE it will be synced back into this repo and included in the next released version. | |||
There was a problem hiding this comment.
Minor, but the website's name seems to be stylized as Crowdin, not CrowdIn (https://www.google.com/search?q=crowdin)
|
LGTM |
tboerger
added
lgtm/done
ethantkoenig
approved these changes
Aug 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@appleboy @lunny, Do we have a rule on total % translated for translation sync?
Closes #2305