Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling in API docs of adminDeleteHook #23995

Closed
wants to merge 0 commits into from
Closed

Fix spelling in API docs of adminDeleteHook #23995

wants to merge 0 commits into from

Conversation

bilogic
Copy link
Contributor

@bilogic bilogic commented Apr 8, 2023 •
edited by techknowlogick

spelling fix

@techknowlogick techknowlogick added this to the 1.20.0 milestone Apr 8, 2023
@techknowlogick techknowlogick added type/bug modifies/api This PR adds API routes or modifies them outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Apr 8, 2023
@techknowlogick
Copy link
Member

thanks for this PR! The CI is failing due to the attached documentation being out of alignment with the code comment, could you run 'make generate-swagger' and commit the result?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 8, 2023
@bilogic
Copy link
Contributor Author

bilogic commented Apr 8, 2023

saw your message after my 2nd commit, let me try make generate-swagger, coz all I did was modify the spelling on github.com itself

@silverwind silverwind changed the title Update hooks.go Fix spelling in API docs of adminDeleteHook Apr 8, 2023
@silverwind
Copy link
Member

Updated the title. You should put descriptive PR titles in the future. And also please don't raise pull requests from your main branch. Create topic branches for each PR.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 24, 2023 •
edited

@bilogic The CI lint still fails. I guess it really needs to run make generate-swagger to re-generate the swagger JSON (the online editor doesn't seem to resolve the problem easily)

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Apr 24, 2023
@silverwind silverwind closed this Apr 24, 2023
@GiteaBot GiteaBot removed this from the 1.20.0 milestone Apr 24, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 24, 2023
@silverwind silverwind mentioned this pull request Apr 24, 2023
Merged
@silverwind
Copy link
Member

Tried to fix this branch but did not work out for some reason, I assume it was because source branch was main and github has special rules around that branch. One should never open a PR from main.

I opened #24310 which contains the commits and the regenration.

silverwind added a commit that referenced this pull request Apr 24, 2023
@silverwind @bilogic
Fix typo in API route (#24310)
fe007b6 
Continuation of #23995

---------

Co-authored-by: bilogic <946010+bilogic@users.noreply.github.com>
@GiteaBot GiteaBot mentioned this pull request Apr 25, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 25, 2023
@silverwind @bilogic @GiteaBot
Fix typo in API route (go-gitea#24310)
93044cd 
Continuation of go-gitea#23995

---------

Co-authored-by: bilogic <946010+bilogic@users.noreply.github.com>
silverwind added a commit that referenced this pull request Apr 25, 2023
@GiteaBot @silverwind @bilogic
Fix typo in API route (#24310) (#24332)
ef3e3af 
Backport #24310 by @silverwind

Continuation of #23995

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: bilogic <946010+bilogic@users.noreply.github.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them outdated/backport/v1.19 This PR should be backported to Gitea 1.19 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bilogic @techknowlogick @silverwind @wxiaoguang @GiteaBot