Make bindata static build parse builtin templates correctly #24003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
approved these changes
Apr 8, 2023
GiteaBot
added
the
lgtm/need 1
lunny
added
type/bug
skip-changelog
|
As it's an emergency bug and I have tested locally. I will merge it with magic. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 10, 2023
* upstream/main: (39 commits) Fix protected branch for API (go-gitea#24013) [skip ci] Updated translations via Crowdin Fix markdownlint (go-gitea#24024) Introduce lint-md and compliance-docs pipeline (go-gitea#24021) Fix https setup doc zh-cn (go-gitea#24015) Replace tribute with text-expander-element for textarea (go-gitea#23985) Improve GetBoards and getDefaultBoard (go-gitea#22981) Expand/Collapse all changed files (go-gitea#23639) Show errors for KaTeX and mermaid on the preview tab (go-gitea#24009) Show protected branch rule names again (go-gitea#23907) Reference the `zh-CN` version of `reverse-proxies` in `https-support` (go-gitea#24016) Fix lint problem in `https-support.zh-cn.md` (go-gitea#24014) docs: HTTPS configuration for zh-cn (go-gitea#23039) Re-add initial wiki page text when editing the page (go-gitea#23984) [skip ci] Updated translations via Crowdin fix: do not escape space between PyPI repository url and package name… (go-gitea#23981) Make bindata static build parse builtin templates correctly (go-gitea#24003) Group template helper functions, remove `Printf`, improve template error messages (go-gitea#23982) Adjust sticky pr header to cover background (go-gitea#23956) Update github.com/google/go-github to v51 (go-gitea#23946) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #24002
Two problems before:
log.Fatalis missing after thesewrapFatalcalls, so the error is not shown to users.GetTemplateAssetNameshas different behaviors for local files and builtin assets, for builtin assets, it also returns directories, so we need to check the extension again.I have tested with
TAGS="bindata sqlite sqlite_unlock_notify" make build && ./gitea, it works well now. Before, the server responds internal server error (because it doesn't complete the template parsing)