Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix orgnization webhooks #2422

Merged
merged 2 commits into from
Aug 30, 2017
Merged

fix orgnization webhooks #2422

merged 2 commits into from
Aug 30, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 29, 2017

fix missing discord webhook wrong route and missing template on orgnization webhooks and fix bug on deliver webhook.

@lunny lunny added the type/bug label Aug 29, 2017
@lunny lunny added this to the 1.3.0 milestone Aug 29, 2017
@lafriks
Copy link
Member

lafriks commented Aug 29, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 29, 2017
@ethantkoenig
Copy link
Member

What was the bug that led to the changes to the HookTask.deliver() method?

@lunny
Copy link
Member Author

lunny commented Aug 30, 2017

@ethantkoenig that should be a bug of GetWebhookByRepoID when the webhook is an orgnization webhook. Then the latest status will not be updated. And I added UpdateWebhookLastStatus for only update the last_statu but not all the columns.

@lunny lunny force-pushed the lunny/fix_missing_discord_webhook branch from e067e90 to 9959df0 Compare August 30, 2017 05:27
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 30, 2017
@lunny lunny merged commit 04ec795 into go-gitea:master Aug 30, 2017
@lunny lunny deleted the lunny/fix_missing_discord_webhook branch August 30, 2017 05:36
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lunny @lafriks @ethantkoenig @tboerger